Yuce Tekol
c30f9bc192
Rows accepts a fields param for backward compat.
2019-01-18 17:41:54 +03:00
Yuce Tekol
dc735c17b8
Fixes #1805 . Fixes Store call error messages
2019-01-16 20:52:33 +03:00
Yuce Tekol
76de81dacf
updated row range test
2019-01-14 23:46:34 +03:00
Yuce Tekol
d75e9eb772
updated row range test
2019-01-14 23:45:58 +03:00
Yuce Tekol
600b39e4e5
updates row range test with a timestamp > the default end timestamp
2019-01-14 23:40:31 +03:00
Yuce Tekol
9f6d489be8
fixes #1823 . Updates tests and docs for row range
2019-01-14 14:39:08 +03:00
Travis Turner
f7e3296f62
fixes a bug on upper end of bsi range queries
2019-01-11 17:05:29 -06:00
Ben Johnson
9d1e5ca8ce
Merge Range() into Row() call.
...
This commit refactors the `Range()` call and merges its functionality
into the `Row()` call.
2019-01-09 15:10:49 -07:00
Yuce Tekol
65c30283d7
adds tests for GroupBy with keys; removes unused Bit message from proto
2019-01-03 15:20:02 +03:00
Matt Jaffee
ed637e6921
add test for group by with invalid filter
2018-12-21 17:24:44 -06:00
Matt Jaffee
81d08be044
fix PQL, Rows and Group By problems
...
make sure that args which are Uints are positive and return an error if not.
improve group by error messages if field for Rows query is invalid
2018-12-21 14:16:55 -06:00
Matt Jaffee
97eb94397f
fix Rows bug where Pilosa would crash without 'field' argument.
2018-12-21 11:55:25 -06:00
Matt Jaffee
45cd48c1b7
change exists field to _exists
2018-12-17 15:44:50 -06:00
Ben Johnson
727659644b
Add GroupBy filter.
2018-12-07 10:35:57 -07:00
Matt Jaffee
a0f4522b6a
fix up linter issues in new groupby/rows tests
2018-10-25 08:35:09 -05:00
Matt Jaffee
21c35e6861
wrap errors, fix comment, add test
2018-10-24 17:18:39 -05:00
Travis Turner
9fee746e76
translate column argument in Rows() query
2018-10-22 17:41:59 -05:00
Matt Jaffee
b6a953cade
cleanup groupby - more comments, remove panic, remove dup test
2018-10-16 19:56:54 -05:00
Matt Jaffee
1029a6ca83
Merge branch 'master' into new-rows-iterate
2018-10-12 19:03:00 -05:00
Matt Jaffee
38f459a6d4
add GroupBy(Rows(column)) test and fix comments
2018-10-12 18:58:27 -05:00
Matt Jaffee
fb706ab883
add GroupBy Rows(limit) test and fix bug
...
run all group by tests on two cluster sizes
2018-10-12 18:47:41 -05:00
Matt Jaffee
431185110b
add different shard test and simplify checking logic
...
we now guarantee result order
2018-10-12 15:58:28 -05:00
Matt Jaffee
a4edd39715
use intersectionCounts for final row of groupBy record
...
since we only need the counts and not the data, this optimization actually
provides enormous speedup (2x?) and massive decrease in allocations.
also in this commit (unfortunately), a bunch of renaming and documentation,
returning a GroupCount from the GroupBy iterator instead of a ppi (ppi is now
gone).
also added TODOs for tests and benchmarks
2018-10-12 15:30:25 -05:00
Matt Jaffee
f9cb7f8fec
add some group by benchmarks
2018-10-11 12:08:17 -05:00
Yuce Tekol
2e2a281e30
More tests for Row call
2018-10-11 17:38:12 +03:00
Matt Jaffee
360623230f
get a somewhat better groupBy working that passes new tests
...
one test still fails due to reordering during merging
2018-10-10 21:03:45 -05:00
Yuce Tekol
616cc0f86b
More refactoring
2018-10-10 17:34:20 +03:00
Yuce Tekol
9a7dac4339
refactored call tests
2018-10-10 17:13:24 +03:00
Matt Jaffee
603b0e5369
fix logic bug applying limit to group by rows
...
check in failing test showing how applying the limit to each rows query can
cause the query to falsely return no results
2018-10-09 19:27:10 -05:00
Matt Jaffee
578c594755
convert GroupBy tests to use new utils; fix case where index exists
2018-10-09 19:13:12 -05:00
Matt Jaffee
45fb6f0c06
add some new test utils and test Rows calls on cluster
2018-10-09 18:44:48 -05:00
Matt Jaffee
36a539d24e
Merge branch 'master' into new-rows-iterate
2018-10-09 12:27:05 -05:00
Yuce Tekol
e3ccece5d2
Merge branch 'master' into 1681-add-missing-call-tests
2018-10-09 17:27:32 +03:00
Yuce Tekol
a08865a2c8
Adds missing rowID/Key columnID/Key tests
2018-10-09 17:24:33 +03:00
Matt Jaffee
cbd7e945b2
get GroupBy working with "Rows" child calls, remove fieldDirectives
...
had to implement decoders for RowIDs and RowIdentifiers - a sign that we need
better testing of remote Rows calls
2018-10-08 19:04:29 -05:00
Yuce Tekol
37d1cfbbd7
Updated with master
2018-10-05 22:07:01 +03:00
Travis Turner
051b71e540
ensure a Range() query with field keys is handled correctly
2018-10-05 11:30:47 -05:00
Travis Turner
3d33cdbb74
implement Store() in the executor (i.e. setRow())
2018-10-05 08:45:07 -05:00
Yuce Tekol
bd48db1435
updated executor.Execute logic for columnAttrs with keys; added columnAttrs with keys test
2018-10-05 16:43:42 +03:00
Matt Jaffee
93e9f242fe
test Rows call with row keys, fix column id problem
2018-09-27 17:07:15 -05:00
Matt Jaffee
7d24276a98
rename "columns" to "rows" in Rows test so it makes sense
2018-09-27 16:18:37 -05:00
Matt Jaffee
78ff75690d
convert Rows to use previous/limit
...
pass previous+1 directly to fragment.rows so that the iterator can seek directly
to the start point. handle limit inside reduce so it can skip out early and
avoid extra allocation.
2018-09-27 16:14:40 -05:00
Matt Jaffee
ac98fcb6d4
rename RowIDs PQL to Rows
2018-09-26 16:09:05 -05:00
Travis Turner
1b6d738bab
Support ranked cache value=0.
...
Since there is no way to remove a value from the cache (because
the interface doesn't support it), this PR modifies the ranked
cache implemetation to allow setting the cache value to 0 for a
row. Doing so effectively removes that row from the cache. Values
below the threshold (other than 0) are still ignored by the
ranked cache's Add() method.
2018-09-24 15:52:44 -05:00
Travis Turner
b6e99734f0
implement ClearRow() query
2018-09-24 15:52:43 -05:00
Travis Turner
4f17dbdbf1
add support for Bool fields
...
prevent import of non-boolean row values to bool fields
2018-09-21 09:25:41 -05:00
Travis Turner
71ad297450
change Rows() to RowIDs() and add RowIdentifiers return type to hold row keys
2018-09-18 12:45:09 -05:00
Travis Turner
f0666b2be0
change GroupByCounts to []GroupCount
2018-09-18 12:39:09 -05:00
Travis Turner
b6d386ba53
fix tests
2018-09-18 12:37:35 -05:00
Travis Turner
e1b938e52c
add FieldRow struct to replace the groupBy string key
2018-09-18 12:36:46 -05:00
