Commit graph

8997 commits

Author SHA1 Message Date
reesporte
5ab83243c6 add tests checking for the proper errors on nil results 2021-12-02 15:47:49 -06:00
Souhaila Noor
50d80f2f1c fixed arg cli descriptions 2021-12-02 14:52:38 -06:00
Souhaila Noor
aebd4c4c62 fixed formatting 2021-12-02 14:22:08 -06:00
Souhaila Noor
7de3eaa935 resolved review's comment 2021-12-02 14:19:59 -06:00
Souhaila Noor
91c8bf5e05 fixed duplicated empty string 2021-12-02 14:04:21 -06:00
Souhaila Noor
214a6dfac4 Merge branch 'fb1031-souhaila' of github.com:molecula/featurebase into fb1031-souhaila 2021-12-02 14:01:06 -06:00
Souhaila Noor
64b31da4a1 resolved duplicated line 2021-12-02 14:00:51 -06:00
souhailanoor
0189b2eef7
Merge branch 'master' into fb1031-souhaila 2021-12-02 13:11:19 -06:00
Souhaila Noor
b5ba3fb2ea added auth arg validation and set up auth package 2021-12-02 13:09:13 -06:00
Seebs
7270016d1a don't explode on translate data restore for _keys
There isn't really a field called _keys but some old backups
will think they have translate data for this. Ignore it politely.

Also in general produce a diagnostic rather than a panic for
translate data restores to nonexistent indexes or fields.
2021-12-01 12:04:24 -06:00
Seebs
8b20406f45 experiment: handle errors more gracefully, but don't stream CreateKeys
We were trying to write an error to a ResponseWriter After attempting to
write to it, and this produces messages about superfluous WriteHeaders,
which is correct. This patch changes things so that we report messages
more clearly and verbosely if we hit them before writing, and if we try
to write and fail, we log the message because that's all we can do.

This does change semantics slightly, in that now we're marshalling
separately from trying to write the marshalled data. I think this is
probably a reasonable call because it lets us get diagnostics about a
hypothetical encoding problem, but in practice I don't think there
should be any encoding problems. So my guess is the actual error will
occur in that last line, and be logged to the server console instead
of failing to write over HTTP.

Also note that this changes some of the messages to include the
underlying error they're complaining about.

We also merge the create/find and index/field cases because only a
couple of lines of code changed between four largeish functions,
and we test some of the failure cases.

We don't have test coverage on the "field isn't provided" type things
because the mux won't actually route things there without them, so
far as I know.
2021-12-01 11:06:54 -06:00
tgruben
73f3c01284
Merge pull request #1790 from molecula/tgruben-patch-1 2021-11-30 21:34:27 -06:00
tgruben
740f3e2838
Merge branch 'master' into tgruben-patch-1 2021-11-30 18:48:41 -06:00
Souhaila Noor
dc1c39fd21 updated featurebase.conf 2021-11-29 16:46:55 -06:00
seebs
21f2868175
Merge pull request #1785 from molecula/sanitycheck
Perform sanity check only if we have the storage it runs on
2021-11-29 09:58:55 -06:00
Souhaila Noor
28e1be7540 added AuthN/AuthZ parameters to featurebase server configuration 2021-11-29 09:40:05 -06:00
tgruben
8b7d429417
Update README.md 2021-11-29 09:18:44 -06:00
souhailanoor
0bcac33313
Merge branch 'master' into sanitycheck 2021-11-24 08:31:13 -06:00
souhailanoor
42f3b79640
Merge pull request #1786 from molecula/fixBugInCicdPipeline
remove duplicate code in multiple stages of gitlab yml for CICD
2021-11-24 08:30:54 -06:00
Souhaila Noor
65c4fc9cdb updated error messages 2021-11-23 20:28:14 -06:00
Souhaila Noor
02b0f4ffd6 test standard condition 2021-11-23 18:50:47 -06:00
Souhaila Noor
0e2d71c303 added error handling 2021-11-23 18:48:06 -06:00
Souhaila Noor
6172f98eab test failed condition 2021-11-23 18:32:09 -06:00
Souhaila Noor
001678386f define ip var 2021-11-23 17:27:57 -06:00
Souhaila Noor
42b6c2b351 updated syntax 2021-11-23 17:25:10 -06:00
Souhaila Noor
afb96f4a9b pass error back to gitlab runner 2021-11-23 17:17:13 -06:00
Souhaila Noor
b243f4b8a3 fix yaml error 2021-11-23 17:10:13 -06:00
Souhaila Noor
d13eef4c4b echo errors 2021-11-23 17:09:35 -06:00
Souhaila Noor
612e11887f added dependency 2021-11-23 16:41:35 -06:00
Souhaila Noor
88c89749af updated job's stage 2021-11-23 16:37:11 -06:00
Souhaila Noor
f03720f0a3 error handling 2021-11-23 16:33:32 -06:00
Souhaila Noor
2de7d2c885 fixed yaml syntax error 2021-11-23 16:26:09 -06:00
Souhaila Noor
0030e759da removed aws config from shell script 2021-11-23 16:24:56 -06:00
Souhaila Noor
d781dfb29b remove error handling to debug 2021-11-23 16:18:14 -06:00
Souhaila Noor
8a77da0db9 removed ssh keys from shell script 2021-11-23 16:14:21 -06:00
Souhaila Noor
184b935550 added print statement 2021-11-23 16:07:22 -06:00
Souhaila Noor
53d7d6b91c fix for ssh-add error 2021-11-23 16:04:29 -06:00
Souhaila Noor
cceb173d5d added before script commands 2021-11-23 15:55:36 -06:00
Souhaila Noor
a6bc10dec9 removed single quotes 2021-11-23 15:50:43 -06:00
Souhaila Noor
dbd1e611d0 changed jobs order 2021-11-23 15:42:12 -06:00
Souhaila Noor
53766f47ca fixed jobs dependencies and added args 2021-11-23 15:38:09 -06:00
Souhaila Noor
aac3b0768c fixed syntax error 2021-11-23 15:32:22 -06:00
Souhaila Noor
97841608e0 switched stages to make testing faster 2021-11-23 15:26:42 -06:00
Souhaila Noor
cce48a2638 created a shell script for deplooying node and handling error conditions 2021-11-23 15:24:47 -06:00
Souhaila Noor
692f2f8cb4 updated dependency of jobs and made instanceId a global variable 2021-11-23 13:29:56 -06:00
Souhaila Noor
7e8cbdeb53 updated a comment to trigger the pipeline for another test 2021-11-23 12:09:51 -06:00
Souhaila Noor
fbf4463572 remove duplicate code in multiple stages 2021-11-23 11:08:14 -06:00
Seebs
14911bfdff Perform sanity check only if we have the storage it runs on
SanityCheckMapping is specific to roaring bitmaps stored in-memory, if
we have an RBF backend, we shouldn't even try it, it'll just panic.

This implies that, in whatever circumstance we were hitting this, we
were getting an error back from the backend. We still need to address
that error, but to do that we need to know what it was, which we don't
if we panic.
2021-11-23 10:22:06 -06:00
Kasey C. Rodgers
769a750cdf
Merge pull request #1775 from molecula/generate-test-data-FB-971
generate csv files that simulate Samsung's data
2021-11-22 15:22:01 -08:00
kcrodgers24
11f1cd3689 Merge branch 'generate-test-data-FB-971' of github.com:molecula/featurebase into generate-test-data-FB-971 2021-11-22 14:55:14 -08:00