Seebs
8e270f9201
provide commented-out test case for bug in dead code
...
bitmapEquals isn't currently being called ever, but it has
an arcane edge-case bug, so I've made the test case for it
and commented it out for future reference.
2018-11-15 15:11:08 -06:00
Seebs
33add4f1e0
proof of concept for stats
...
This commit adds some trivial stat-tracking which can be
observed at localhost:10101/debug/vars. However, writes to
a locking data structure aren't cheap, so the stat-tracking
is by default not compiled. To build it, add the build
tag `roaringstats`, which will cause the `statsHit` function
to actually do something. Otherwise, it's an empty and
inlineable function, meaning the compiler throws it away
entirely.
This would, in principle, let us get additional visibility
into edge cases and which code paths are hot. This is not
the same thing as profiling for overall performance; the
stat counts aren't affected by whether a particular code path
is using a large amount of CPU time, just reporting how
often it happens at all.
2018-11-15 15:10:48 -06:00
Yuce Tekol
70f85211d9
prevent panic in Bitmap.UnmarshalBinary when there is no data
2018-11-15 22:06:21 +03:00
Todd Gruben
6aad568f28
added TODO(2.0) comment
2018-09-25 11:07:01 -05:00
Todd Gruben
be3bc105cd
fixed upconvert;reverted to released interface
2018-09-25 10:40:04 -05:00
Todd Gruben
64e86614f8
shrank n(container bit count cache) to int32
2018-09-25 09:14:19 -05:00
Matt Jaffee
3ca7944fe3
remove unecessary lines
...
confirmed that bounds checks are still avoided by
go test -gcflags="-d=ssa/check_bce/debug=1"
./roaring.go:3387:8: Found IsSliceInBounds
./roaring.go:3388:8: Found IsSliceInBounds
./roaring.go:3436:21: Found IsSliceInBounds
2018-09-20 12:37:28 -05:00
tgruben
9b0cc07b30
Merge branch 'master' into bounds-check
2018-09-20 09:09:27 -05:00
Yuce Tekol
fcdc3b7427
trivial comment fix
2018-09-19 20:54:06 +03:00
Yuce Tekol
e664a0e42f
rename add -> DirectAdd
2018-09-17 20:25:14 +03:00
Yuce Tekol
37fdd73a7f
DirectAdd adds a single value
2018-09-17 17:16:03 +03:00
Yuce Tekol
09c24cd3be
Changed the signature of Bitmap.DirectAdd function
2018-09-17 17:10:02 +03:00
Yuce Tekol
266051dd26
Adds DirectAdd function to roaring.Bitmap
2018-09-17 16:25:34 +03:00
Todd Gruben
fe8756927c
manual gofmt
2018-09-14 15:40:37 -05:00
Todd Gruben
51e57ad550
code cleanup
2018-09-14 14:46:02 -05:00
tgruben
eb7af13be2
Merge branch 'master' into bounds-check
2018-09-14 14:37:23 -05:00
Todd Gruben
136ee7beab
updated comments and gofmt
2018-09-14 10:27:33 -05:00
Matt Jaffee
b412309447
rename standard roaring to "official" throughout
2018-09-13 13:38:18 -05:00
Matt Jaffee
b2ec5e373e
fixup explanatory comment
2018-09-13 13:33:51 -05:00
Matt Jaffee
4a5f12631c
more naked returns
2018-09-12 17:29:35 -05:00
Matt Jaffee
3bc9c66f5e
remove some naked returns and simplify
2018-09-12 17:21:17 -05:00
Matt Jaffee
a3243f99e1
linter fixes - reorder return vals, remove unused const
2018-09-12 13:24:59 -05:00
Matt Jaffee
8254d0fadd
improve import roaring docs, check errors
2018-09-12 12:08:57 -05:00
Matt Jaffee
d3717e2afe
make Bitmap.UnmarshalBinary work for roaring or pilosa format
2018-09-12 10:50:05 -05:00
Todd Gruben
93e5767325
cleanup #1622
2018-09-06 16:27:10 -05:00
Travis Turner
8a1f8659fa
change test to use exported UnmarshalStandardRoaring()
2018-09-05 10:13:15 -05:00
Todd Gruben
1d99da1f28
added support for both pilosa and standard roaring uploads
2018-09-05 10:13:15 -05:00
Todd Gruben
cc80e0b0e4
initial support for bulk importing standard roaring files per shard
2018-09-05 10:13:15 -05:00
Todd Gruben
019ca63cf4
add support for reading standard roaring bitmaps to pilosa/roaring.
2018-09-05 10:13:15 -05:00
Todd Gruben
38e3ce10fe
removing bounds check
2018-09-04 14:01:26 -05:00
Cody Soyland
f01d850b17
Fix linter issues: gosimple
2018-07-20 09:06:43 -05:00
Cody Soyland
0a9e6bca7a
Re-add return variable names removed in 2aa4d6b1.
2018-07-19 08:09:05 -05:00
Cody Soyland
3ca51989c2
Merge branch 'master' into 1515-metalinter-nakedret
2018-07-19 07:52:58 -05:00
Cody Soyland
2aa4d6b12f
Fix linter issues: nakedret
2018-07-18 15:23:36 -05:00
Cody Soyland
d4510172d3
Fix linter issues: ineffassign
2018-07-18 14:02:56 -05:00
Cody Soyland
a962a0c526
Fix linter issues: deadcode
2018-07-17 17:17:42 -05:00
Travis Turner
a26ebe3e23
frag.rows() and frag.rowsForColumn() from #1496
2018-07-17 15:11:45 -05:00
Cody Soyland
1c7f77d002
Merge branch 'develop'
2018-07-06 07:52:29 -05:00
Cody Soyland
31cab33fbe
Unexport roaring.SliceIterator
2018-07-05 23:11:56 -05:00
Cody Soyland
c134535229
Unexport roaring.SliceContainers
2018-07-05 23:11:56 -05:00
Cody Soyland
89c28043dd
Unexport roaring.RunMaxSize
2018-07-05 23:11:56 -05:00
Cody Soyland
5ec9d3af22
Unexport roaring.NewSliceContainers
2018-07-05 23:11:56 -05:00
Cody Soyland
67cfe4dcee
Unexport roaring.ContainerRun
2018-07-05 23:11:56 -05:00
Cody Soyland
bdd4fb51ef
Unexport roaring.ContainerInfo
2018-07-05 23:11:56 -05:00
Cody Soyland
692b72be18
Unexport roaring.ContainerBitmap
2018-07-05 23:11:56 -05:00
Cody Soyland
9098b0d131
Unexport roaring.ContainerArray
2018-07-05 23:11:56 -05:00
Cody Soyland
72fcb37f80
Unexport roaring.Container.Optimize
2018-07-05 23:11:56 -05:00
Cody Soyland
c73fc795da
Unexport roaring.BitmapInfo
2018-07-05 23:11:56 -05:00
Travis Turner
5dd7a9556a
rename slice to shard
2018-06-28 14:07:07 -05:00
Todd Gruben
df492090b0
backfill fix for issue #1400
2018-06-22 14:32:42 -05:00