Todd Gruben
e5e2237fc0
changed order of logger options
2018-10-17 11:12:37 -05:00
tgruben
96e7107870
Merge branch 'master' into fix-logger
2018-10-17 10:52:51 -05:00
Ben Johnson
442c872b33
Merge pull request #1624 from benbjohnson/delete-available-shard
...
Add DeleteAvailableShard()
2018-10-17 09:47:35 -06:00
Todd Gruben
0df193cf98
revert to existing api with panic per jaffee
2018-10-17 10:29:58 -05:00
Ben Johnson
f8608227d1
Add DeleteAvailableShard()
...
This commit adds the ability to remove an 'available shard'
from the shard cache. This does not affect shards known to be
available because of local data.
2018-10-17 08:50:06 -06:00
Matt Jaffee
b6a953cade
cleanup groupby - more comments, remove panic, remove dup test
2018-10-16 19:56:54 -05:00
Matt Jaffee
1029a6ca83
Merge branch 'master' into new-rows-iterate
2018-10-12 19:03:00 -05:00
Matt Jaffee
38f459a6d4
add GroupBy(Rows(column)) test and fix comments
2018-10-12 18:58:27 -05:00
Matt Jaffee
fb706ab883
add GroupBy Rows(limit) test and fix bug
...
run all group by tests on two cluster sizes
2018-10-12 18:47:41 -05:00
Matt Jaffee
431185110b
add different shard test and simplify checking logic
...
we now guarantee result order
2018-10-12 15:58:28 -05:00
Matt Jaffee
a4edd39715
use intersectionCounts for final row of groupBy record
...
since we only need the counts and not the data, this optimization actually
provides enormous speedup (2x?) and massive decrease in allocations.
also in this commit (unfortunately), a bunch of renaming and documentation,
returning a GroupCount from the GroupBy iterator instead of a ppi (ppi is now
gone).
also added TODOs for tests and benchmarks
2018-10-12 15:30:25 -05:00
tgruben
1d102e283d
Merge branch 'master' into fix-logger
2018-10-12 02:11:44 -05:00
Matt Jaffee
07d279a155
implement mergeGroupCounts w/o map, remove dead code
...
move rowFilters to fragment.go
new mergeGroupCounts implementation takes limit into account while merging,
exploits inherent order of group count results.
2018-10-11 19:06:46 -05:00
Yuce Tekol
db76437d50
Merge pull request #1683 from yuce/1681-add-missing-call-tests
...
Adds missing rowID/Key columnID/Key tests
2018-10-12 02:51:48 +03:00
Matt Jaffee
9d896c5d2f
implement alternate groupByIterator using fragment rowIterator
...
doesn't re-intersect the same rows for every record
2018-10-11 18:01:44 -05:00
Yuce Tekol
d1dbee749b
Merge branch 'master' into 1681-add-missing-call-tests
2018-10-11 21:37:40 +03:00
Matt Jaffee
f9cb7f8fec
add some group by benchmarks
2018-10-11 12:08:17 -05:00
Yuce Tekol
2e2a281e30
More tests for Row call
2018-10-11 17:38:12 +03:00
Travis Turner
f62dbc00b9
Merge pull request #1686 from travisturner/holder-reopen
...
allow holder to close/open/close without panic on closing closed channel
2018-10-11 07:25:53 -05:00
tgruben
1895233ed8
Merge branch 'master' into fix-logger
2018-10-11 06:58:17 -05:00
Travis Turner
69ef4a3746
allow holder to close/open/close without panic on closing closed channel
2018-10-10 21:29:03 -05:00
Matt Jaffee
360623230f
get a somewhat better groupBy working that passes new tests
...
one test still fails due to reordering during merging
2018-10-10 21:03:45 -05:00
Yuce Tekol
616cc0f86b
More refactoring
2018-10-10 17:34:20 +03:00
Yuce Tekol
9a7dac4339
refactored call tests
2018-10-10 17:13:24 +03:00
Matt Jaffee
603b0e5369
fix logic bug applying limit to group by rows
...
check in failing test showing how applying the limit to each rows query can
cause the query to falsely return no results
2018-10-09 19:27:10 -05:00
Matt Jaffee
578c594755
convert GroupBy tests to use new utils; fix case where index exists
2018-10-09 19:13:12 -05:00
Matt Jaffee
45fb6f0c06
add some new test utils and test Rows calls on cluster
2018-10-09 18:44:48 -05:00
Matt Jaffee
36a539d24e
Merge branch 'master' into new-rows-iterate
2018-10-09 12:27:05 -05:00
Matt Jaffee
1474884f5d
use existing var instead of recalculating
...
silly mistake - thanks todd
2018-10-09 10:27:57 -05:00
Yuce Tekol
e3ccece5d2
Merge branch 'master' into 1681-add-missing-call-tests
2018-10-09 17:27:32 +03:00
Yuce Tekol
a08865a2c8
Adds missing rowID/Key columnID/Key tests
2018-10-09 17:24:33 +03:00
Matt Jaffee
e2bbcb28e5
fix linter issues
2018-10-08 19:10:16 -05:00
Matt Jaffee
cbd7e945b2
get GroupBy working with "Rows" child calls, remove fieldDirectives
...
had to implement decoders for RowIDs and RowIdentifiers - a sign that we need
better testing of remote Rows calls
2018-10-08 19:04:29 -05:00
Matt Jaffee
c172ca0680
combine fragment.rows and rowsForColumn with generalized filter
...
use filter funcs with closures for state instead of methods on structs. seems a
bit cleaner.
2018-10-08 16:16:39 -05:00
Yuce Tekol
396ec6e271
Merge pull request #1677 from yuce/1632-move-columnattrs
...
Fixes #1632
2018-10-05 22:53:17 +03:00
Yuce Tekol
37d1cfbbd7
Updated with master
2018-10-05 22:07:01 +03:00
Travis Turner
2d81d85c4d
Merge pull request #1679 from travisturner/range-with-keys
...
ensure a Range() query with field keys is handled correctly
2018-10-05 11:35:30 -05:00
Travis Turner
051b71e540
ensure a Range() query with field keys is handled correctly
2018-10-05 11:30:47 -05:00
Travis Turner
87a2bff58f
Merge pull request #1666 from travisturner/store-function
...
Store() function
2018-10-05 10:52:04 -05:00
Yuce Tekol
b617db84eb
gfmt'ed
2018-10-05 17:44:02 +03:00
Yuce Tekol
b6981930b1
ColumnAttrsSet omit empty ID
2018-10-05 16:47:53 +03:00
Travis Turner
16811bc04c
add a "store intersect" example to the Store() docs
2018-10-05 08:45:07 -05:00
Travis Turner
a6190f5cfa
Store() docs
2018-10-05 08:45:07 -05:00
Travis Turner
338f69b71d
replace switch with simplified if statement
2018-10-05 08:45:07 -05:00
Travis Turner
3d33cdbb74
implement Store() in the executor (i.e. setRow())
2018-10-05 08:45:07 -05:00
Travis Turner
619bc1bcd9
implements fragment.setRow(row, rowID)
2018-10-05 08:45:05 -05:00
Yuce Tekol
bd48db1435
updated executor.Execute logic for columnAttrs with keys; added columnAttrs with keys test
2018-10-05 16:43:42 +03:00
Yuce Tekol
a028d4604a
Merge branch 'master' into 1632-move-columnattrs
2018-10-05 15:16:17 +03:00
Yuce Tekol
19177b94d1
Merge pull request #1672 from yuce/1637-trackexistence-by-default
...
Index trackExistence is true by default Fixes #1637
2018-10-04 22:02:25 +03:00
Yuce Tekol
b3efa25516
Merge branch 'master' into 1637-trackexistence-by-default
2018-10-04 21:47:22 +03:00
