Travis Turner
06f5d04f1c
swap out mapVector for rowsVector in mutex fields
2018-07-19 14:01:30 -05:00
Travis Turner
a07ed360ab
add mutex field type
2018-07-19 14:01:29 -05:00
Matt Jaffee
68f341ea9f
fix race cond in translate_test
...
implements locked Reader method on test.TranslateFile. This race condition is
only present in tests, and is due to a replica referring directly to a primary
instead of through an http.TranslateStore as it would in production. This patch
requires the replica to obtain a lock while accessing the primary, and requires
test.Reopen to obtain a lock when swapping out the pilosa.TranslateStore.
I was able to reproduce the race by running: "go test
-run=TestTranslateFile_PrimaryTranslateStore -race -count=10", and could not
reproduce it after this patch.
Somewhat unrelated, I came across a "fatal error: fault" triggered by trying to
print an open pilosa.TranslateFile. This seems to be related to the mmapped
".data" field. I wrote the test to document the issue, but I don't think it's
easily fixable.
2018-07-19 12:06:31 -05:00
Cody Soyland
de99b5720f
Fix linter issues: vet
2018-07-19 11:37:50 -05:00
Cody Soyland
9be45bcd60
Merge pull request #1539 from codysoyland/1512-metalinter-maligned
...
Fix linter issues: maligned
2018-07-19 11:21:38 -05:00
Cody Soyland
187ded0a52
Fix linter issues: maligned
2018-07-19 11:07:59 -05:00
Matthew Jaffee
e4eef98a77
Merge pull request #1533 from jaffee/1370-cluster-locking
...
1370 cluster locking
2018-07-19 10:18:11 -05:00
Matt Jaffee
30e0d42c3d
remove incorrect nodeJoin comment
2018-07-19 09:43:48 -05:00
Matt Jaffee
774e91ad30
finish commenting methods as unprotected.
2018-07-19 09:40:23 -05:00
Matt Jaffee
3b8b190849
add nolint unparam for setStateAndBroadcast
2018-07-19 09:17:36 -05:00
Matt Jaffee
d8597f320a
Merge branch 'master' into 1370-cluster-locking
2018-07-19 08:57:28 -05:00
Cody Soyland
18a19d2f2a
Merge pull request #1537 from codysoyland/1515-metalinter-nakedret
...
Fix linter issues: nakedret
2018-07-19 08:57:13 -05:00
Cody Soyland
0a9e6bca7a
Re-add return variable names removed in 2aa4d6b1.
2018-07-19 08:09:05 -05:00
Cody Soyland
3ca51989c2
Merge branch 'master' into 1515-metalinter-nakedret
2018-07-19 07:52:58 -05:00
Cody Soyland
6bb6edf2fb
Merge pull request #1536 from codysoyland/1510-metalinter-ineffassign
...
Fix linter issues: ineffassign
2018-07-18 18:15:53 -05:00
Matt Jaffee
e1e4df67bc
fix race conds and add more locking/annotation
2018-07-18 16:47:24 -05:00
Cody Soyland
7bd2405765
Merge branch 'master' into 1510-metalinter-ineffassign
2018-07-18 16:28:49 -05:00
Cody Soyland
d27f8caacb
Merge pull request #1535 from codysoyland/1508-metalinter-gochecknoinits
...
Fix linter issues: gochecknoinits
2018-07-18 16:28:25 -05:00
Cody Soyland
2aa4d6b12f
Fix linter issues: nakedret
2018-07-18 15:23:36 -05:00
Cody Soyland
d4510172d3
Fix linter issues: ineffassign
2018-07-18 14:02:56 -05:00
Cody Soyland
0b86bbb4f5
Fix linter issues: gochecknoinits
2018-07-18 11:58:27 -05:00
Cody Soyland
cceb1ebdf6
Merge pull request #1534 from codysoyland/1505-metalinter-deadcode
...
Fix linter issues: deadcode
2018-07-18 10:27:03 -05:00
Cody Soyland
a962a0c526
Fix linter issues: deadcode
2018-07-17 17:17:42 -05:00
Travis Turner
4490f246cc
Merge pull request #1532 from travisturner/fragment-rows
...
Fragment rows() and rowsForColumn()
2018-07-17 17:03:52 -05:00
Matt Jaffee
fa755fdd81
fix ClusterCluster not to broadcast to self.
...
stops deadlock when cluster has appropriate internal locking
2018-07-17 16:34:49 -05:00
Matt Jaffee
7efdacd028
rename setState to unprotected
2018-07-17 16:34:48 -05:00
Matt Jaffee
18321b88f9
rename setID as unprotected and add some "unprotected" comments
2018-07-17 16:34:48 -05:00
Matt Jaffee
04bdc67d7f
rename a few things to unprotected* and use safe coordinatorNode in setNodeState
2018-07-17 16:34:48 -05:00
Matt Jaffee
8b2d8295d1
rename cluster.coordinatorNode to unprotectedCoordinatorNode
2018-07-17 16:34:48 -05:00
Travis Turner
dc5d7a66ef
ensure that changing ShardWidth is supported in rowsForColumn()
2018-07-17 16:21:35 -05:00
Travis Turner
07abb505cc
add more testing to row iteration
2018-07-17 15:11:45 -05:00
Travis Turner
a26ebe3e23
frag.rows() and frag.rowsForColumn() from #1496
2018-07-17 15:11:45 -05:00
Cody Soyland
4aa57f56a4
Merge pull request #1530 from codysoyland/1511-metalinter-interfacer
...
Fix linter issues: interfacer
2018-07-17 14:15:18 -05:00
Cody Soyland
486edbec43
Merge branch 'master' into 1511-metalinter-interfacer
2018-07-17 13:41:11 -05:00
Cody Soyland
3017740f3a
Merge pull request #1529 from codysoyland/1514-metalinter-misspell
...
Fix linter issues: misspell
2018-07-17 13:38:43 -05:00
Cody Soyland
8efbb02fb1
Merge branch 'master' into 1514-metalinter-misspell
2018-07-17 12:38:12 -05:00
Cody Soyland
97b0bcfcc2
Merge pull request #1528 from codysoyland/1515-metalinter-unparam
...
Fix linter issues: unparam
2018-07-17 12:37:03 -05:00
Cody Soyland
573ec91fc2
Fix linter issues: interfacer
2018-07-17 12:36:02 -05:00
Cody Soyland
2635759893
Fix linter issues: misspell
2018-07-17 12:22:41 -05:00
Cody Soyland
f9625ef4fa
Fix linter issues: unparam
2018-07-17 12:05:07 -05:00
Cody Soyland
379e5daf44
Merge pull request #1526 from codysoyland/1525-metalinter-goimports
...
Fix linter issue: goimports
2018-07-17 08:03:27 -05:00
Cody Soyland
8917359960
Merge branch 'master' into 1525-metalinter-goimports
2018-07-17 07:54:48 -05:00
Cody Soyland
b67bd2bf3f
Merge pull request #1527 from codysoyland/1509-metalinter-gofmt
...
Fix linter issues: gofmt
2018-07-17 07:51:51 -05:00
Cody Soyland
c464e0fe64
Fix linter issues: gofmt
2018-07-16 16:45:42 -05:00
Cody Soyland
34e3d21b34
Fix linter issue: goimports
2018-07-16 16:31:46 -05:00
Cody Soyland
7e3ae59ec3
Merge pull request #1504 from codysoyland/ci-staging
...
Add TravisCI staged builds
2018-07-16 14:54:29 -05:00
Cody Soyland
471cf38a56
Add TravisCI staged builds
...
Creates the following 3 stages:
1. add cached vendor directory, run metalinter
2. tests with env matrix
3. prerelease compilation/upload
2018-07-16 08:09:39 -05:00
Cody Soyland
fa6e0da1bb
Merge pull request #1503 from codysoyland/docs-fix
...
Remove errant char at top of query language doc
2018-07-13 09:39:49 -05:00
Matthew Jaffee
88f405a916
Merge branch 'master' into docs-fix
2018-07-13 09:28:22 -05:00
Cody Soyland
927a7f0cd9
Remove errant char at top of query language doc
2018-07-13 09:09:16 -05:00
