From fc1de2dba9074176d687d944e7dbae6e5fed5300 Mon Sep 17 00:00:00 2001 From: Travis Turner Date: Fri, 18 Jan 2019 14:49:58 -0600 Subject: [PATCH] cluster.Nodes() just needs a read lock --- cluster.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cluster.go b/cluster.go index e966c57a1..cbdb9f547 100644 --- a/cluster.go +++ b/cluster.go @@ -609,8 +609,8 @@ func (c *cluster) addNodeBasicSorted(node *Node) bool { // Nodes returns a copy of the slice of nodes in the cluster. Safe for // concurrent use, result may be modified. func (c *cluster) Nodes() []*Node { - c.mu.Lock() - defer c.mu.Unlock() + c.mu.RLock() + defer c.mu.RUnlock() ret := make([]*Node, len(c.nodes)) copy(ret, c.nodes) return ret