scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed issue with interplay between count(*) and _id column (#2250)

Browse source
This commit is contained in:
Pat Okeeffe 2023-02-14 18:40:15 -06:00 • committed by GitHub
parent 6bf693b98c
commit f205459003
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sql3/planner/planoptimizer.go
View file

@ -644,7 +644,13 @@ func tryToReplaceGroupByWithPQLAggregate(ctx context.Context, a *ExecutionPlanne
}
switch aggregable.AggExpression().Type().(type) {
case *parser.DataTypeID, *parser.DataTypeString:
return thisNode, true, nil
// if it is any other column other than _id bail
ref, ok := aggregable.AggExpression().(*qualifiedRefPlanExpression)
if ok {
if !strings.EqualFold(ref.columnName, "_id") {
return thisNode, true, nil
}
}
}
}