mirror of
https://github.com/featurebasedb/featurebase.git
synced 2026-09-07 00:55:55 +00:00
uprev golangci-lint, fix a minor lint in rbf
I have a newer staticcheck and golangci-lint on my laptop, and it started complaining about something. The first comment added disables the check in staticcheck-as-a-command, the second disables it when it's being done by golangci-lint, which invokes the analysis passes directly and displays the output differently, and also doesn't recognize the hints used by staticcheck. Newer golangci-lint doesn't find anything else that it wants to complain about.
This commit is contained in:
parent
092177aea4
commit
ed309821ae
2 changed files with 3 additions and 2 deletions
|
|
@ -53,7 +53,7 @@ jobs:
|
|||
name: golang
|
||||
steps:
|
||||
- checkout-plus
|
||||
- run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sudo sh -s -- -b /usr/local/bin v1.23.8
|
||||
- run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sudo sh -s -- -b /usr/local/bin v1.31.0
|
||||
- run: make golangci-lint
|
||||
go-mod-tidy:
|
||||
executor:
|
||||
|
|
|
|||
|
|
@ -96,7 +96,8 @@ func (tx *Tx) Commit() error {
|
|||
for _, path := range tx.updatedSegmentPaths {
|
||||
segment := walSegmentByPath(tx.segments, path)
|
||||
assert(segment != nil)
|
||||
tx.db.updateWALSegment(*segment)
|
||||
//lint:ignore SA5011 the assert above prevents this from being nil
|
||||
tx.db.updateWALSegment(*segment) //nolint:staticcheck
|
||||
}
|
||||
tx.db.mu.Unlock()
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue