scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-07 00:55:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed malformed offset bug in readWithRuns

Browse source
This commit is contained in:
Ashley Svetlik 2019-06-24 12:51:10 -05:00
parent 8fd23239a1
commit eb5d1ae1a4
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
roaring/fuzz_test.go
View file

@ -57,6 +57,10 @@ func TestUnmarshalBinary(t *testing.T) {
cr: []byte("<0\x00\x02\x03\x00\x00\x00쳫\v\x00d9\v\x00\x009\v"), //<0쳫 d9 9
expected: "unmarshaling as pilosa roaring: malformed bitmap, key-cardinality not provided for 0 containers",
},
{ // Checks for incomplete offset in readWithRuns
cr: []byte(";0\x000\v00000"), //";00 00000"
expected: "reading offsets from official roaring format: offset incomplete: len=10",
},
}
for _, crash := range confirmedCrashers {

11
roaring/roaring.go
View file

@ -4510,7 +4510,10 @@ func (b *Bitmap) UnmarshalBinary(data []byte) error {
// Read container offsets and attach data.
if haveRuns {
readWithRuns(b, data, pos, keyN)
err := readWithRuns(b, data, pos, keyN)
if err != nil {
return errors.Wrap(err, "reading offsets from official roaring format")
}
} else {
err := readOffsets(b, data, pos, keyN)
if err != nil {
@ -4545,7 +4548,10 @@ func readOffsets(b *Bitmap, data []byte, pos int, keyN uint32) error {
return nil
}
func readWithRuns(b *Bitmap, data []byte, pos int, keyN uint32) {
func readWithRuns(b *Bitmap, data []byte, pos int, keyN uint32) error {
if len(data) < pos+runCountHeaderSize {
return fmt.Errorf("offset incomplete: len=%d", len(data))
}
citer, _ := b.Containers.Iterator(0)
for i := 0; i < int(keyN); i++ {
citer.Next()
@ -4568,6 +4574,7 @@ func readWithRuns(b *Bitmap, data []byte, pos int, keyN uint32) {
pos += bitmapN * 8
}
}
return nil
}
// handledIter and handledIters are wrappers around Bitmap Container iterators