scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-06 16:45:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1074 from jaten-molecula/fsync_applies_to_all

Browse source 
apply --fsync flag to all tx backend
This commit is contained in:
tgruben 2020-11-06 12:34:28 -06:00 • committed by GitHub
commit e99f7f0fc3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
bolt.go
View file

@ -164,8 +164,14 @@ func (r *boltRegistrar) OpenDBWrapper(path0 string, doAllocZero bool, rbfcfg *rb
// re-sync during recovery.
// NoFreelistSync bool
//db.NoSync = true
//db.NoFreelistSync = true
if rbfcfg != nil && !rbfcfg.FsyncEnabled {
db.NoSync = true
db.NoFreelistSync = true
} else {
// default to using fsync on bolt.
db.NoSync = false
db.NoFreelistSync = false
}
err = db.Update(func(tx *bolt.Tx) (err error) {
_, err = tx.CreateBucketIfNotExists(bucketCT)

22
lmdb.go
View file

@ -183,13 +183,6 @@ func (r *lmdbRegistrar) OpenDBWrapper(path0 string, doAllocZero bool, rbfcfg *rb
// flags = flags | lmdb.WriteMap | lmdb.NoMetaSync | lmdb.NoSync // about the same speed
// flags = flags | lmdb.NoMetaSync | lmdb.NoSync // slows things down
// TODO(jea): we got an odd segfault in the roaring/ pkg when we went to read-only mmap
// with the row-cache off; probably means we were trying to write to mmap-ed
// memory. Investigate at some point. reference: 2a77b25d ja/write_map_prevents_segfault
//
// Update: added COW to roaring/roaring.go:3282 func (c *Container) arrayRemove(),
// seems to fix the issue.
//
//flags = flags | lmdb.WriteMap // seems faster than without: or maybe not. not sure.
// kRemove N= 710401 avg/op: 7.714µs sd: 27.83µs total: 5.480656859s
// kAdd N= 722835 avg/op: 9.096µs sd: 105.787µs total: 6.575497725s
@ -202,12 +195,17 @@ func (r *lmdbRegistrar) OpenDBWrapper(path0 string, doAllocZero bool, rbfcfg *rb
// On my darwin/OSX laptop with 16GB ram, for instance, we
// can have difficulty obtaining this, resulting in
// panic: mdb_env_open: no space left on device
lmdb.WriteMap | // Use a writable memory map.
lmdb.WriteMap // Use a writable memory map.
// default ACI (not Durable) transactions; 300% faster write speed results.
lmdb.NoMetaSync | // Don't fsync metapage after commit.
lmdb.NoSync | // Don't fsync after commit.
lmdb.MapAsync // Flush asynchronously when using the WriteMap flag.
if rbfcfg == nil || !rbfcfg.FsyncEnabled {
// default for lmdb: fsync off.
// unsafe, but get upper bound on performance.
flags = flags |
// default ACI (not Durable) transactions; 300% faster write speed results.
lmdb.NoMetaSync | // Don't fsync metapage after commit.
lmdb.NoSync | // Don't fsync after commit.
lmdb.MapAsync // Flush asynchronously when using the WriteMap flag.
}
if !DirExists(path) {
panicOn(os.MkdirAll(path, 0755))

4
rbf/cfg/cfg.go
View file

@ -58,5 +58,7 @@ func (cfg *Config) DefineFlags(flags *pflag.FlagSet) {
flags.DurationVar(&cfg.CheckpointEveryDur, "rbf-checkpoint-dur", default0.CheckpointEveryDur,
"RBF checkpoint on the next write that occurs this long or more after the previous write. 0 means checkpoint after every write.")
flags.Int64Var(&cfg.MaxSize, "rbf-max-db-size", default0.MaxSize, "RBF maximum size in bytes of a database file (distinct from a WAL file)")
flags.BoolVar(&cfg.FsyncEnabled, "rbf-fsync", default0.FsyncEnabled, "RBF: enable fsync fully safe flush-to-disk at each checkpoint")
// renamed from --rbf-fsync to just --fsync because now it applies to all Tx backends.
flags.BoolVar(&cfg.FsyncEnabled, "fsync", default0.FsyncEnabled, "enable fsync fully safe flush-to-disk")
}