From e7241ac024772c04aefe10f41663796cafdff7ca Mon Sep 17 00:00:00 2001 From: Matthew Jaffee Date: Tue, 15 Feb 2022 14:20:58 -0600 Subject: [PATCH] fix tag check to check against null empty string doesn't work because gitlab doesn't set the variable at all. How do I know that "null" is correct? Because Fletcher told me... apparently it's a ruby-ism --- .gitlab/.gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab/.gitlab-ci.yml b/.gitlab/.gitlab-ci.yml index 09860b40a..9d8d5c420 100644 --- a/.gitlab/.gitlab-ci.yml +++ b/.gitlab/.gitlab-ci.yml @@ -450,7 +450,7 @@ s3 dump: tags: - shell rules: - - if: '$CI_COMMIT_TAG == "" && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")' + - if: '$CI_COMMIT_TAG == null && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")' script: - aws configure set aws_access_key_id $AWS_FBCI_ACCESS_KEY_ID - aws configure set aws_secret_access_key $AWS_FBCI_SECRET_ACCESS_KEY @@ -497,7 +497,7 @@ s3 dump tag: tags: - shell rules: - - if: '$CI_COMMIT_TAG != "" && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")' + - if: '$CI_COMMIT_TAG != null && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")' script: - aws configure set aws_access_key_id $AWS_FBCI_ACCESS_KEY_ID - aws configure set aws_secret_access_key $AWS_FBCI_SECRET_ACCESS_KEY