scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-15 08:41:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove round trip

Browse source
This commit is contained in:
Todd Gruben 2022-03-11 06:12:38 -06:00
parent 82d3f54a28
commit e64dde0b4c
1 changed files with 10 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
executor.go
View file

@ -8242,24 +8242,12 @@ func (e *executor) executeDeleteRecords(ctx context.Context, qcx *Qcx, index str
} else if len(c.Children) > 1 {
return false, errors.New("Delete() only accepts a single bitmap input")
}
if len(c.Children) != 1 {
}
row, err := e.executeBitmapCall(ctx, qcx, index, c.Children[0], shards, opt)
qcx.Abort()
qcx.Reset() //release the qcx to allow for rbf checkpoint
// Execute calls in bulk on each remote node and merge.
mapFn := func(ctx context.Context, shard uint64, mopt *mapOptions) (_ interface{}, err error) {
for i := range row.segments {
if row.segments[i].shard == shard {
return e.executeDeleteRecordFromShard(ctx, index, row.segments[i].data, shard)
}
}
return false, nil
return e.executeDeleteRecordFromShard(ctx, index, c.Children[0], shard)
}
// Merge returned results at coordinating node.
@ -8293,18 +8281,23 @@ func transactExistRow(ctx context.Context, idx *Index, shard uint64, frag *fragm
}
return rowID, tx.Commit()
}
func (e *executor) executeDeleteRecordFromShard(ctx context.Context, index string, columns *roaring.Bitmap, shard uint64) (changed bool, err error) {
func (e *executor) executeDeleteRecordFromShard(ctx context.Context, index string, bmCall *pql.Call, shard uint64) (changed bool, err error) {
span, _ := tracing.StartSpanFromContext(ctx, "Executor.executeDeleteRecordFromShard")
defer span.Finish()
if columns.Count() == 0 {
return
}
// Fetch index.
idx := e.Holder.Index(index)
if idx == nil {
err = newNotFoundError(ErrIndexNotFound, index)
return
}
qcx := idx.Txf().NewQcx()
//bmCall is a bitmap
row, err := e.executeBitmapCallShard(ctx, qcx, index, bmCall, shard)
qcx.Abort()
columns := row.segments[0].data
if columns.Count() == 0 {
return
}
src := NewRowFromBitmap(columns)
return DeleteRowsWithFlow(ctx, src, idx, shard, true)
}