scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-10-07 19:37:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Handle errors

Browse source
This commit is contained in:
Cody Soyland 2021-02-01 09:23:30 -06:00
parent 367425bba1
commit e2331372d8
No known key found for this signature in database
GPG key ID: 6F5D2986DCC5DC8A
2 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
server/grpc.go
View file

@ -148,9 +148,12 @@ func (h *GRPCHandler) QuerySQL(req *pb.QuerySQLRequest, stream pb.Pilosa_QuerySQ
return err
}
stream.SendHeader(metadata.New(map[string]string{
err = stream.SendHeader(metadata.New(map[string]string{
"duration": strconv.Itoa(int(duration)),
}))
if err != nil {
return errors.Wrap(err, "sending header")
}
err = newDurationRowser(results, duration).ToRows(stream.Send)
if err != nil {
@ -191,9 +194,12 @@ func (h *GRPCHandler) QuerySQLUnary(ctx context.Context, req *pb.QuerySQLRequest
}
duration := time.Since(start)
table.Duration = int64(duration)
grpc.SendHeader(ctx, metadata.New(map[string]string{
err = grpc.SendHeader(ctx, metadata.New(map[string]string{
"duration": strconv.Itoa(int(duration)),
}))
if err != nil {
return nil, errors.Wrap(err, "sending header")
}
return table, nil
}
@ -209,9 +215,12 @@ func (h *GRPCHandler) QueryPQL(req *pb.QueryPQLRequest, stream pb.Pilosa_QueryPQ
resp, err := h.api.Query(stream.Context(), &query)
durQuery := time.Since(t)
stream.SendHeader(metadata.New(map[string]string{
err = stream.SendHeader(metadata.New(map[string]string{
"duration": strconv.Itoa(int(durQuery)),
}))
if err != nil {
return errors.Wrap(err, "sending header")
}
// TODO: what about resp.CollumnAttrSets?
if err != nil {
@ -280,9 +289,12 @@ func (h *GRPCHandler) QueryPQLUnary(ctx context.Context, req *pb.QueryPQLRequest
duration := durQuery + durFormat
table.Duration = int64(duration)
grpc.SendHeader(ctx, metadata.New(map[string]string{
err = grpc.SendHeader(ctx, metadata.New(map[string]string{
"duration": strconv.Itoa(int(duration)),
}))
if err != nil {
return nil, errors.Wrap(err, "sending header")
}
h.stats.Timing(pilosa.MetricGRPCUnaryQueryDurationSeconds, durQuery, 0.1)
h.stats.Timing(pilosa.MetricGRPCUnaryFormatDurationSeconds, durFormat, 0.1)

2
server/grpc_test.go
View file

@ -1462,7 +1462,7 @@ func (m *mockPilosa_QuerySQLServer) SetHeader(md metadata.MD) error {
}
func (m *mockPilosa_QuerySQLServer) SetTrailer(md metadata.MD) {
m.MockServerTransportStream.SetTrailer(md)
_ = m.MockServerTransportStream.SetTrailer(md)
}
func (m *mockPilosa_QuerySQLServer) Context() context.Context {