From 14319cc54bc08d34551221edf9832dcfe78feca0 Mon Sep 17 00:00:00 2001 From: Cody Soyland Date: Thu, 2 Apr 2020 12:12:07 -0500 Subject: [PATCH 1/2] Use "make test-race" instead of custom test flags in CI --- .circleci/config.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ca992bcfe..dc8aa1251 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -70,6 +70,9 @@ jobs: shard_width: type: string default: "20" + test_make_target: + type: string + default: "test" test_flags: type: string default: "" @@ -85,7 +88,7 @@ jobs: - add-github-auth - run: sudo apt-get install lsof - run: - command: make test SHARD_WIDTH=<< parameters.shard_width >> TESTFLAGS="<< parameters.test_flags >>" GOARCH=<< parameters.goarch >> + command: make << parameters.test_make_target >> SHARD_WIDTH=<< parameters.shard_width >> GOARCH=<< parameters.goarch >> no_output_timeout: 30m cluster-tests: executor: @@ -187,7 +190,7 @@ workflows: - setup - test: name: test-race - test_flags: -race -v -timeout=30m + test_make_target: test-race requires: - setup - test: From 6a639efdba92a348681d374c2028e64dc22524f2 Mon Sep 17 00:00:00 2001 From: Cody Soyland Date: Thu, 2 Apr 2020 12:12:17 -0500 Subject: [PATCH 2/2] Modify Docker Hub deployment filter rules. The documentation is unclear/incorrect, and these filters aren't behaving correctly. This is an attempt at fixing that. More info at: https://discuss.circleci.com/t/job-runs-even-when-tags-ignore-filter-is-triggered-when-combined-with-branches-only/20664/11 --- .circleci/config.yml | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index dc8aa1251..dd72390e8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -211,20 +211,6 @@ workflows: - linter - check-license-headers - test-golang-1.14 - - dockerhub-upload: - name: dockerhub-upload-stable - tag_branch: true - tag_tag: true - tag_latest: true - requires: - - linter - - check-license-headers - - test-golang-1.14 - filters: - branches: - ignore: /.*/ - tags: - only: /^v.*/ - dockerhub-upload: name: dockerhub-upload-unstable tag_branch: true @@ -237,5 +223,17 @@ workflows: filters: branches: only: enterprise + - dockerhub-upload: + name: dockerhub-upload-stable + tag_branch: true + tag_tag: true + tag_latest: true + requires: + - linter + - check-license-headers + - test-golang-1.14 + filters: tags: - ignore: /^v.*/ + only: /^v.*/ + branches: + ignore: /.*/