scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-12 07:41:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

pass group membership thru context

Browse source
This commit is contained in:
Samir Patel 2021-12-28 17:36:52 -05:00
parent e5fa99a531
commit d95d4dac9d
1 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
http/handler.go
View file

@ -283,6 +283,7 @@ type contextKeyQuery int
const (
contextKeyQueryRequest contextKeyQuery = iota
contextKeyQueryError
contextKeyGroupMembership
)
// addQueryContext puts the results of handler.readQueryRequest into the Context for use by
@ -547,6 +548,7 @@ func (h *Handler) mwAuth(handler http.HandlerFunc, perm authz.Permission) http.H
}
p, err := h.permissions.GetPermissions(groups, indexName)
//check error
uinfo := h.auth.GetUserInfo(w, r)
//get query string if applicable
@ -563,13 +565,17 @@ func (h *Handler) mwAuth(handler http.HandlerFunc, perm authz.Permission) http.H
perm = authz.Write
}
}
h.querylogger.Infof("User ID: %s, User Name: %s, Endpoint: %s, Index: %s, Query: %s, Err: %v", uinfo.UserID, uinfo.UserName, r.URL.Path, indexName, queryString, err)
if perm != authz.Admin {
h.querylogger.Infof("User ID: %s, User Name: %s, Endpoint: %s, Index: %s, Query: %s, Err: %v", uinfo.UserID, uinfo.UserName, r.URL.Path, indexName, queryString, err)
}
if err != nil || !authz.IsComparable(p, perm.String()) {
w.Header().Add("Content-Type", "text/plain")
w.WriteHeader(http.StatusForbidden)
return
}
ctx := context.WithValue(r.Context(), contextKeyGroupMembership, groups)
handler.ServeHTTP(w, r.WithContext(ctx))
}
handler.ServeHTTP(w, r)
@ -744,6 +750,15 @@ func headerAcceptRoaringRow(header http.Header) bool {
return false
}
//WIP
func (h *Handler) filterResponse(schema []*pilosa.IndexInfo, g []authn.Group) {
// if h.auth != nil{
// indexes := h.permissions.GetAuthorizedIndexList(g, authz.Read.String())
// }
}
// handleGetSchema handles GET /schema requests.
func (h *Handler) handleGetSchema(w http.ResponseWriter, r *http.Request) {
if !validHeaderAcceptJSON(r.Header) {
@ -760,6 +775,9 @@ func (h *Handler) handleGetSchema(w http.ResponseWriter, r *http.Request) {
h.logger.Printf("getting schema error: %s", err)
}
groups := r.Context().Value(contextKeyGroupMembership)
h.filterResponse(schema, groups.([]authn.Group))
if err := json.NewEncoder(w).Encode(pilosa.Schema{Indexes: schema}); err != nil {
h.logger.Errorf("write schema response error: %s", err)
}