Add support for drop table

This commit is contained in:
Kuba Podgórski 2020-08-24 13:24:18 +02:00
parent 9caa670c90
commit ceda4ab61b
3 changed files with 94 additions and 7 deletions

View file

@ -709,6 +709,7 @@ func TestQuerySQLUnary(t *testing.T) {
{"Table", "string"},
},
rows: []row{
{[]columnResponse{"delete_me"}},
{[]columnResponse{"grouper"}},
{[]columnResponse{"joiner"}},
},
@ -731,6 +732,27 @@ func TestQuerySQLUnary(t *testing.T) {
},
eq: equal,
},
{
sql: "drop table delete_me",
exp: tableResponse{
headers: []columnInfo{},
rows: []row{},
},
eq: equal,
},
{
sql: "show tables",
exp: tableResponse{
headers: []columnInfo{
{"Table", "string"},
},
rows: []row{
{[]columnResponse{"grouper"}},
{[]columnResponse{"joiner"}},
},
},
eq: equal,
},
}
for i, test := range tests {
@ -881,6 +903,9 @@ func setUpTestQuerySQLUnary(ctx context.Context, t *testing.T) (gh *server.GRPCH
}
}
// delete_me
m.MustCreateIndex(t, "delete_me", pilosa.IndexOptions{TrackExistence: true})
return gh, func() {
if err := m.API.DeleteIndex(ctx, joiner.Name()); err != nil {
panic(err)

View file

@ -38,17 +38,14 @@ func execSQL(ctx context.Context, api *pilosa.API, logger logger.Logger, querySt
case sql.SQLTypeSelect:
handler := sql.NewSelectHandler(api)
results, err = handler.Handle(ctx, query)
if err != nil {
return nil, errors.Wrap(err, "failed to start SQL query")
}
case sql.SQLTypeShow:
handler := sql.NewShowHandler(api)
results, err = handler.Handle(ctx, query)
if err != nil {
return nil, errors.Wrap(err, "failed to start SQL query")
}
case sql.SQLTypeEmpty:
handler := sql.NewDDLHandler(api)
results, err = handler.Handle(ctx, query)
default:
return nil, status.Errorf(codes.Unimplemented, "query type not supported")
}
return results, nil
return results, errors.Wrap(err, "failed to start SQL query")
}

65
sql/ddl.go Normal file
View file

@ -0,0 +1,65 @@
// Copyright 2020 Pilosa Corp.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package sql
import (
"context"
"fmt"
"github.com/pilosa/pilosa/v2"
pproto "github.com/pilosa/pilosa/v2/proto"
"github.com/pkg/errors"
"vitess.io/vitess/go/vt/sqlparser"
)
// DDLHandler executes CREATE, ALTER, DROP, RENAME, TRUNCATE or ANALYZE statement.
type DDLHandler struct {
api *pilosa.API
}
// NewDDLHandler constructor
func NewDDLHandler(api *pilosa.API) *DDLHandler {
return &DDLHandler{
api: api,
}
}
// Handle executes mapped SQL
func (h *DDLHandler) Handle(ctx context.Context, mapped *MappedSQL) (pproto.StreamClient, error) {
stmt, ok := mapped.Statement.(*sqlparser.DDL)
if !ok {
return nil, fmt.Errorf("statement is not type DDL: %T", mapped.Statement)
}
switch stmt.Action {
case sqlparser.DropStr:
return h.execDropTable(ctx, stmt)
default:
return nil, errors.Errorf("unsupported DDL action: %s", stmt.Action)
}
}
func (h *DDLHandler) execDropTable(ctx context.Context, stmt *sqlparser.DDL) (pproto.StreamClient, error) {
if n := len(stmt.FromTables); n != 1 {
return nil, fmt.Errorf("statement can only contain a single drop table, but got: %d", n)
}
indexName := stmt.FromTables[0].ToViewName().Name.String()
if err := h.api.DeleteIndex(ctx, indexName); err != nil {
return nil, errors.Wrapf(err, "deleting index %s", indexName)
}
return pproto.EmptyStream{}, nil
}