scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-06 16:45:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Added Travis's note about InteraClient interface

Browse source
This commit is contained in:
Yuce Tekol 2017-10-23 17:34:04 +03:00
parent 642bf3180f
commit c9cb92c96b
No known key found for this signature in database
GPG key ID: CB59E46D2FB90573
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
client.go
View file

@ -32,6 +32,7 @@ import (
"time"
"crypto/tls"
"github.com/gogo/protobuf/proto"
"github.com/pilosa/pilosa/internal"
)
@ -1206,6 +1207,12 @@ func nodePathToURL(node *Node, path string) url.URL {
}
}
// InternalClient should be implemented by any struct that enables any transport between nodes
// TODO: Refactor
// Note from Travis: Typically an interface containing more than two or three methods is an indication that
// something hasn't been architected correctly.
// While I understand that putting the entire Client behind an interface might require this many methods,
// I don't want to let it go unquestioned.
type InternalClient interface {
MaxSliceByIndex(ctx context.Context) (map[string]uint64, error)
MaxInverseSliceByIndex(ctx context.Context) (map[string]uint64, error)