From c99faa17934871916798fb7ff3684b9819fb47d7 Mon Sep 17 00:00:00 2001 From: Seebs Date: Thu, 10 Nov 2022 10:27:43 -0600 Subject: [PATCH] bump timeout on overlapping write requests test At 50ms, we see sporadic failures in CI. So much for "this should only need a couple milliseconds". Bumped timeout to avoid that. The challenge here is that we have some tests which *want* to hit the timeout to confirm that we aren't allowing things we shouldn't. But we don't want the test to hang forever. But we want to be sure it is actually stuck and not just being slow... (cherry picked from commit f1a68f8a829a7df638a0677b5e1c2f3e9849ed54) --- querycontext/query_context_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/querycontext/query_context_test.go b/querycontext/query_context_test.go index fe4ea409e..8fd66c340 100644 --- a/querycontext/query_context_test.go +++ b/querycontext/query_context_test.go @@ -400,7 +400,7 @@ func testOverlappingWriteRequests(t *testing.T, write overlappingWriteReqs) erro } t.Fatalf("running reqs: %v", err) } - case <-time.After(50 * time.Millisecond): + case <-time.After(250 * time.Millisecond): if !write.shouldError { // Only log this if we didn't expect an error. t.Logf("write requests (%d):", len(write.reqs))