don't panic on failed table creation

The attempt to set the TrackExistence option for fields
happened before checking whether the field was created
successfully or not. Credit to Rachith for spotting this.
Bug was introduced with the TrackExistence stuff, but
we apparently never had a test case for invalid min/max
values.

sql3/planner/opaltertable.go

@@ -94,11 +94,11 @@ func (i *alterTableRowIter) Next(ctx context.Context) (types.Row, error) {
 		fos := i.columnDef.fos
 
 		fld, err := pilosa.FieldFromFieldOptions(fname, fos...)
-		// all newly created fields unconditionally have TrackExistence turned on.
-		fld.Options.TrackExistence = true
 		if err != nil {
 			return nil, err
 		}
+		// all newly created fields unconditionally have TrackExistence turned on.
+		fld.Options.TrackExistence = true
 
 		if err := i.planner.schemaAPI.CreateField(ctx, tname, fld); err != nil {
 			return nil, err

sql3/planner/opcreatetable.go

@@ -112,11 +112,11 @@ func (i *createTableRowIter) Next(ctx context.Context) (types.Row, error) {
 
 	for _, f := range i.columns {
 		fld, err := pilosa.FieldFromFieldOptions(dax.FieldName(f.name), f.fos...)
-		// We unconditionally turn on TrackExistence for all newly-created fields.
-		fld.Options.TrackExistence = true
 		if err != nil {
 			return nil, errors.Wrapf(err, "creating field from field options: %s", f.name)
 		}
+		// We unconditionally turn on TrackExistence for all newly-created fields.
+		fld.Options.TrackExistence = true
 		fields = append(fields, fld)
 	}
 

sql3/test/defs/defs_create_table.go

@@ -31,6 +31,13 @@ var createTable = TableTest{
 			),
 			ExpErr: "expected literal, found bad",
 		},
+		{
+			name: "minAboveMax",
+			SQLs: sqls(
+				"create table bar (_id id, i1 int min 20 max 19)",
+			),
+			ExpErr: "int field min cannot be greater than max",
+		},
 		{
 			name: "commentString",
 			SQLs: sqls(