scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Re-allowed concurrency for molecula-consumer-csv when not using '--auto-generate' (#2294)

Browse source 
Concurrency was previously fully disabled due to duplication when using '--auto-generate' but testing has shown that it works correctly when not using that flag. Added the required check and updated help text
This commit is contained in:
Bruce Baranowski 2022-11-15 15:55:57 -05:00 • committed by GitHub
parent f1a68f8a82
commit ba70bee875
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
idk/cmd/molecula-consumer-csv/main.go
View file

@ -30,8 +30,8 @@ func main() {
return
}
if m.Concurrency != 1 {
m.Log().Infof("Concurrency is not supported for csv ingest. '--concurrency' flag will be ignored.")
if m.Concurrency != 1 && m.AutoGenerate == true {
m.Log().Infof("Concurrency is not supported for csv ingest when using '--auto-generate'. '--concurrency' flag will be ignored and concurrency will be set to 1.")
m.Concurrency = 1
}

2
idk/ingest.go
View file

@ -69,7 +69,7 @@ type Main struct {
AutoGenerate bool `short:"a" help:"Automatically generate IDs."`
ExternalGenerate bool `short:"" help:"Use FeatureBase's ID generation (must be set alongside auto-generate)."`
IDAllocKeyPrefix string `short:"" help:"A prefix for ID allocator keys when using FeatureBase's ID generation (must be different for each concurrent ingester)."`
Concurrency int `short:"c" help:"Number of concurrent sources and indexing routines to launch. Concurrency is not supported for molecula-consumer-csv and molecula-consumer-sql"`
Concurrency int `short:"c" help:"Number of concurrent sources and indexing routines to launch. Concurrency is not supported for molecula-consumer-sql. Concurrency for molecula-consumer-csv only works when providing multiple files and does not support '--auto-generate'"`
CacheLength uint64 `short:"" help:"Number of batches of ID mappings to cache."`
PackBools string `short:"k" help:"If non-empty, boolean fields will be packed into two set fields—one with this name, and one with <name>-exists."`
Verbose bool `short:"v" help:"Enable verbose logging."`