scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove field name argument from Frame.Value()

Browse source
This commit is contained in:
Travis Turner 2018-06-04 20:00:30 -05:00
parent 127d7a7298
commit b566fd278a
No known key found for this signature in database
GPG key ID: 7F08008DFD9314C9
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
executor_test.go
View file

@ -290,7 +290,7 @@ func TestExecutor_Execute_SetValue(t *testing.T) {
}
f := hldr.Frame("i", "f")
if value, exists, err := f.Value(10, "f"); err != nil {
if value, exists, err := f.Value(10); err != nil {
t.Fatal(err)
} else if !exists {
t.Fatal("expected value to exist")
@ -298,7 +298,7 @@ func TestExecutor_Execute_SetValue(t *testing.T) {
t.Fatalf("unexpected value: %v", value)
}
if value, exists, err := f.Value(100, "f"); err != nil {
if value, exists, err := f.Value(100); err != nil {
t.Fatal(err)
} else if !exists {
t.Fatal("expected value to exist")

6
frame.go
View file

@ -706,14 +706,14 @@ func (f *Frame) ClearBit(name string, rowID, colID uint64, t *time.Time) (change
}
// Value reads a bsiGroup value for a column.
func (f *Frame) Value(columnID uint64, name string) (value int64, exists bool, err error) {
field := f.bsiGroup(name)
func (f *Frame) Value(columnID uint64) (value int64, exists bool, err error) {
field := f.bsiGroup(f.name)
if field == nil {
return 0, false, ErrBSIGroupNotFound
}
// Fetch target view.
view := f.View(viewBSIGroupPrefix + name)
view := f.View(viewBSIGroupPrefix + f.name)
if view == nil {
return 0, false, nil
}

4
frame_test.go
View file

@ -94,7 +94,7 @@ func TestFrame_SetValue(t *testing.T) {
}
// Read value.
if value, exists, err := f.Value(100, "f"); err != nil {
if value, exists, err := f.Value(100); err != nil {
t.Fatal(err)
} else if value != 21 {
t.Fatalf("unexpected value: %d", value)
@ -138,7 +138,7 @@ func TestFrame_SetValue(t *testing.T) {
}
// Read value.
if value, exists, err := f.Value(100, "f"); err != nil {
if value, exists, err := f.Value(100); err != nil {
t.Fatal(err)
} else if value != 23 {
t.Fatalf("unexpected value: %d", value)