scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

add horrifying code to skip rows with count 0 in Group By

Browse source
This commit is contained in:
Matt Jaffee 2018-12-21 17:40:50 -06:00
parent 25f83cedc2
commit aa0d64047d
No known key found for this signature in database
GPG key ID: 08A3DFFF987B11BF
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
executor.go
View file

@ -2836,6 +2836,7 @@ func newGroupByIterator(rowIDs []RowIDs, children []*pql.Call, filter *Row, inde
// nextAtIdx is a recursive helper method for getting the next row for the field
// at index i, and then updating the rows in the "higher" fields if it wraps.
func (gbi *groupByIterator) nextAtIdx(i int) {
TOP:
nr, rowID, wrapped := gbi.rowIters[i].Next()
if nr == nil {
gbi.done = true
@ -2852,11 +2853,18 @@ func (gbi *groupByIterator) nextAtIdx(i int) {
gbi.rows[i].row = nr.Intersect(gbi.rows[i-1].row)
}
gbi.rows[i].id = rowID
if gbi.rows[i].row.Count() == 0 {
goto TOP // I wanted to just call nextAtIdx again, but if a bunch of
// rows in a row were 0, I was worried we'd get into a stack
// overflow situation
}
}
// Next returns a GroupCount representing the next group by record. When there
// are no more records it will return an empty GroupCount and done==true.
func (gbi *groupByIterator) Next() (ret GroupCount, done bool) {
TOPNEXT:
if gbi.done {
return ret, true
}
@ -2865,6 +2873,10 @@ func (gbi *groupByIterator) Next() (ret GroupCount, done bool) {
} else {
ret.Count = gbi.rows[len(gbi.rows)-1].row.intersectionCount(gbi.rows[len(gbi.rows)-2].row)
}
if ret.Count == 0 {
gbi.nextAtIdx(len(gbi.rows) - 1)
goto TOPNEXT
}
ret.Group = make([]FieldRow, len(gbi.rows))
copy(ret.Group, gbi.fields)
@ -2873,6 +2885,7 @@ func (gbi *groupByIterator) Next() (ret GroupCount, done bool) {
}
// set up for next call
gbi.nextAtIdx(len(gbi.rows) - 1)
return ret, false