From a5dda0cb1ca78d53ef893af5554e100eb24bf820 Mon Sep 17 00:00:00 2001 From: Seebs Date: Thu, 30 Mar 2023 17:27:38 -0500 Subject: [PATCH] off-by-v error in spelling of versions --- idk/ingest_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/idk/ingest_test.go b/idk/ingest_test.go index 378f3c742..4c4b2c3b5 100644 --- a/idk/ingest_test.go +++ b/idk/ingest_test.go @@ -93,8 +93,10 @@ func TestFeaturebaseVersion(t *testing.T) { if expectedTag != "" { // if a tag is set, we're in a tagged pipeline, and the version // should just be vX.Y or something similar, without a commit - // hash. - if v != expectedTag { + // hash. in that case, the tag passed to us from the environment + // will look like vX.Y, but the version reported by the version + // endpoint is just X.Y. Argh. + if v != expectedTag && ("v"+v) != expectedTag { t.Fatalf("version %s does not match expected tag %s", v, expectedTag) } t.Logf("featurebase version %q matches expectations", expectedTag)