scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-11 23:31:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #380 from travisturner/v0.2-top-n

Browse source 
Move the top-n `trim` performance enhancement over to the v0.2 branch.
This commit is contained in:
Travis Turner 2017-03-09 09:34:58 -06:00 • committed by GitHub
commit 99d930ce64
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
executor.go
View file

@ -182,7 +182,16 @@ func (e *Executor) executeTopN(ctx context.Context, db string, c *pql.TopN, slic
other.BitmapIDs = Pairs(pairs).Keys()
sort.Sort(uint64Slice(other.BitmapIDs))
return e.executeTopNSlices(ctx, db, &other, slices, opt)
trimmedList, err := e.executeTopNSlices(ctx, db, &other, slices, opt)
if err != nil {
return nil, err
}
if c.N != 0 && int(c.N) < len(trimmedList) {
trimmedList = trimmedList[0:c.N]
}
return trimmedList, nil
}
func (e *Executor) executeTopNSlices(ctx context.Context, db string, c *pql.TopN, slices []uint64, opt *ExecOptions) ([]Pair, error) {
@ -206,11 +215,6 @@ func (e *Executor) executeTopNSlices(ctx context.Context, db string, c *pql.TopN
// Sort final merged results.
sort.Sort(Pairs(results))
// Only keep the top n after sorting.
if c.N > 0 && len(results) > c.N {
results = results[0:c.N]
}
return results, nil
}