scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #494 from jaffee/cacheCheckv20

Browse source 
further checking about possible row cache errors
This commit is contained in:
Matthew Jaffee 2020-06-25 21:24:01 -05:00 • committed by GitHub
commit 93b29fba23
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
fragment.go
View file

@ -556,6 +556,17 @@ func (f *fragment) unprotectedSetBit(rowID, columnID uint64) (changed bool, err
// Don't update the cache if nothing changed.
if !changed {
row, _ := f.rowCache.Fetch(rowID)
if row != nil && !row.Includes(columnID) {
// paranoia time. It should be impossible for the
// rowCache to have an entry which lacks a bit which is
// in storage, but we've seen some behavior which
// indicated this is happening... so we'll check and
// clear the rowCache rather than risking returning
// inconsistent data in a query.
f.Logger.Printf("INCONSISTENT: index:%s field:%s found bit row/col %d/%d not in cache after in storage; dropping cached row, consider restarting Pilosa.", f.index, f.field, rowID, columnID)
f.rowCache.Add(rowID, nil)
}
return changed, nil
}

13
roaring/roaring.go
View file

@ -21,6 +21,7 @@ import (
"hash/fnv"
"io"
"math/bits"
"os"
"reflect"
"sort"
"unsafe"
@ -3190,6 +3191,9 @@ func (c *Container) arrayRemove(v uint16) (*Container, bool) {
}
// removing the last item? we can just return the empty container.
if c.N() == 1 {
if c.flags&(flagFrozen|flagMapped) != 0 {
fmt.Fprintf(os.Stderr, "INCONSISTENT: array remove of %d setting N in another container\n", v)
}
c.n = 0
return nil, true
}
@ -3207,6 +3211,9 @@ func (c *Container) bitmapRemove(v uint16) (*Container, bool) {
}
// removing the last item? we can just return the empty container.
if c.N() == 1 {
if c.flags&(flagFrozen|flagMapped) != 0 {
fmt.Fprintf(os.Stderr, "INCONSISTENT: bitmap remove of %d setting N in another container\n", v)
}
c.n = 0
return nil, true
}
@ -3233,6 +3240,9 @@ func (c *Container) runRemove(v uint16) (*Container, bool) {
}
// removing the last item? we can just return the empty container.
if c.N() == 1 {
if c.flags&(flagFrozen|flagMapped) != 0 {
fmt.Fprintf(os.Stderr, "INCONSISTENT: run remove of %d setting N in another container\n", v)
}
c.n = 0
return nil, true
}
@ -4292,6 +4302,9 @@ func unionArrayArrayInPlace(a, b *Container) *Container {
// ... but we also want to be sure we don't end up
// copying in a mapped object into our not-mapped
// object.
if !b.Mapped() {
fmt.Fprintf(os.Stderr, "INCONSISTENT: unionArrayArray referencing array of %d elements\n", b.N())
}
a.setArrayMaybeCopy(b.array(), b.Mapped())
return a.optimize()
}

6
roaring/roaring_helpers_test.go
View file

@ -251,12 +251,12 @@ type testOp struct {
func doContainer(typ byte, data interface{}) *Container {
switch typ {
case containerArray:
return NewContainerArray(data.([]uint16))
return NewContainerArray(data.([]uint16)).Freeze()
case containerBitmap:
c := NewContainerBitmap(-1, data.([]uint64))
c := NewContainerBitmap(-1, data.([]uint64)).Freeze()
return c
case containerRun:
return NewContainerRun(data.([]interval16))
return NewContainerRun(data.([]interval16)).Freeze()
}
return nil
}