scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-11 07:11:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

use testhook to run server tests so we can have post-processing and audits

Browse source 
This gives more consistency with the other tests and allows us to get audit
checks on the server/ tests. The tests on the clients being closed are
temporarily disabled because they tend to think the last test's clients
are "still open" for a few seconds after the test completes.
This commit is contained in:
Seebs 2021-02-23 11:49:04 -06:00
parent 2ee589ae1d
commit 8d6f97604f
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
etcd/embed.go
View file

@ -873,7 +873,12 @@ type hookedClient struct {
}
func (h *hookedClient) Close() {
_ = testhook.Closed(pilosa.NewAuditor(), h.Client, nil)
// The hook open/closed test here is disabled because there's a
// slight delay before the client actually gets closed in
// some cases, which is long enough to frequently be caught
// if there was a client in the last test run, even though it'd
// be fine a few seconds later.
// _ = testhook.Closed(pilosa.NewAuditor(), h.Client, nil)
h.Client.Close()
}
@ -885,7 +890,8 @@ func (e *Etcd) client() (*hookedClient, error) {
return nil, errors.Wrapf(err, "creates a new etcd client from URLs (%v)", urls)
}
_ = testhook.Opened(pilosa.NewAuditor(), cli, nil)
// Temporarily disabled, see comment in Close above.
// _ = testhook.Opened(pilosa.NewAuditor(), cli, nil)
return &hookedClient{Client: cli}, nil
}

4
server/server_test.go
View file

@ -24,7 +24,6 @@ import (
"math/rand"
"net"
nethttp "net/http"
"os"
"reflect"
"sort"
"strings"
@ -38,6 +37,7 @@ import (
"github.com/pilosa/pilosa/v2/roaring"
"github.com/pilosa/pilosa/v2/server"
"github.com/pilosa/pilosa/v2/test"
"github.com/pilosa/pilosa/v2/testhook"
"github.com/pkg/errors"
"golang.org/x/sync/errgroup"
)
@ -1202,7 +1202,7 @@ func TestMain(m *testing.M) {
panic(err)
}
}()
os.Exit(m.Run())
testhook.RunTestsWithHooks(m)
}
// TestClusterCreatedAtRace is a regression test for an issue where