diff --git a/holder.go b/holder.go index 2d0e592b9..531f4beec 100644 --- a/holder.go +++ b/holder.go @@ -371,10 +371,10 @@ func (h *Holder) DeleteIndex(name string) error { h.mu.Lock() defer h.mu.Unlock() - // Ignore if index doesn't exist. + // Confirm index exists. index := h.index(name) if index == nil { - return nil + return NotFoundError{ErrIndexNotFound} } // Close index. diff --git a/index.go b/index.go index e57afe60e..43f5ce552 100644 --- a/index.go +++ b/index.go @@ -346,10 +346,10 @@ func (i *Index) DeleteField(name string) error { i.mu.Lock() defer i.mu.Unlock() - // Ignore if field doesn't exist. + // Confirm field exists. f := i.field(name) if f == nil { - return nil + return NotFoundError{ErrFieldNotFound} } // Close field. diff --git a/index_test.go b/index_test.go index d1a740a4f..bfb54c680 100644 --- a/index_test.go +++ b/index_test.go @@ -194,13 +194,14 @@ func TestIndex_DeleteField(t *testing.T) { t.Fatal("expected nil field") } - // Delete again to make sure it doesn't error. - if err := index.DeleteField("f"); err != nil { + // Delete again to make sure it errors. + err := index.DeleteField("f") + if err == nil || err.Error() != pilosa.ErrFieldNotFound.Error() { t.Fatal(err) } } -// Ensure index can delete a field. +// Ensure index can validate its name. func TestIndex_InvalidName(t *testing.T) { path, err := ioutil.TempDir("", "pilosa-index-") if err != nil {