scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-13 08:01:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

try to reduce seeking in ApplyRewriter a little

Browse source 
Slightly more careful thoughts about whether or not the cursor
is "dirty".
This commit is contained in:
Seebs 2022-03-31 10:33:46 -05:00
parent 919eb3f0e8
commit 88a6a047d2
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
rbf/tx.go
View file

@ -1791,6 +1791,7 @@ func (s *containerFilter) ApplyRewriter() (err error) {
if err != nil {
return err
}
dirty = true
} else {
exact = true
}
@ -1798,14 +1799,21 @@ func (s *containerFilter) ApplyRewriter() (err error) {
if exact {
err = s.cursor.deleteLeafCell(uint64(updateKey))
key = ^roaring.FilterKey(0)
// if we got here by a seek, we're already marked dirty,
// but if we're on a cell and delete it, we've invalidated
// our cursor position.
dirty = true
}
// if we don't delete, we aren't changing our situation at all
} else {
cell = ConvertToLeafArgs(uint64(updateKey), data)
err = s.cursor.putLeafCell(cell)
key = ^roaring.FilterKey(0)
// no dirty flag here; if we had to seek, the cursor became
// dirty (is no longer pointed at the key we thought it was
// pointed to, so the main loop would want to seek), and if
// we didn't seek, we're still where we used to be.
}
dirty = true
return err
}
for err := s.cursor.Next(); err == nil; err = s.cursor.Next() {