scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add test coverage to expressionanalyzer.go (#2370)

Browse source 
analyzeExpression - tupleLiteralExpression was covered by something
else between the ticket getting filed and me starting on it.
(*ExecutionPlanner).analyzeBinaryExpression now has increased
coverage for IN / NOT IN. Several bugs got revealed by adding tests;
those tests are commented out but can be re-enabled by whoever ends
up working on the bugs. Tickets are filed.
This commit is contained in:
Lory Cloutier 2023-04-06 09:55:09 -05:00 • committed by GitHub
parent ea72396b4d
commit 875999e30d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 128 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sql3/planner/expressionanalyzer.go
View file

@ -632,7 +632,7 @@ func (p *ExecutionPlanner) analyzeBinaryExpression(ctx context.Context, expr *pa
if ok {
//we have a select in the expression list so make sure it is the only thing in the expression list
if len(lst.Exprs) > 1 {
return nil, sql3.NewErrInternalf("expresion list should only contain one select statement")
return nil, sql3.NewErrInternalf("expression list should only contain one select statement")
}
//make sure select only returns one column
if len(sel.Columns) > 1 {

24
sql3/test/defs/defs_delete.go
View file

@ -118,6 +118,30 @@ var deleteTests = TableTest{
ExpRows: rows(),
Compare: CompareExactUnordered,
},
// inner joins in delete are apparently not supported yet
// when they are, this will fill in test coverage for expressionanalyzer.go
/*
{
SQLs: sqls(
"delete from del_all_types a1 inner join del_all_types a2 on a1._id=a2._id where a1._id in (select _id from del_all_types);",
),
ExpHdrs: hdrs(
hdr("_id", fldTypeID),
),
ExpRows: rows(),
Compare: CompareExactUnordered,
},
{
SQLs: sqls(
"select _id from del_all_types;",
),
ExpHdrs: hdrs(
hdr("_id", fldTypeID),
),
ExpRows: rows(),
Compare: CompareExactUnordered,
},
*/
// dates
{

103
sql3/test/defs/defs_in.go
View file

@ -128,6 +128,51 @@ var inTests = TableTest{
),
Compare: CompareExactUnordered,
},
{
SQLs: sqls(
"select t1._id in (select t2._id from in_all_types as t2) from in_all_types as t1",
),
ExpHdrs: hdrs(
hdr("", fldTypeBool),
),
ExpRows: rows(
row(bool(true)),
),
Compare: CompareExactUnordered,
},
// This test fails - re-enable it when fixing the bug
/*
{
SQLs: sqls(
"select t1._id in (select t2.id1 from in_all_types as t2) from in_all_types as t1",
),
ExpHdrs: hdrs(
hdr("", fldTypeBool),
),
ExpRows: rows(
row(bool(false)),
),
Compare: CompareExactUnordered,
},
*/
// This test also fails.
// Once re-enabled and passing, it provides coverage for expressionanalyzer.go
// (*ExecutionPlanner).analyzeBinaryExpression in the case where the left hand side
// of the IN contains a JOIN.
/*
{
SQLs: sqls(
"select a1._id from in_all_types a1 inner join in_all_types a2 on a1._id=a2._id where a1._id in (select _id from in_all_types);",
),
ExpHdrs: hdrs(
hdr("", fldTypeBool),
),
ExpRows: rows(
row(bool(true)),
),
Compare: CompareExactUnordered,
},
*/
},
}
@ -259,5 +304,63 @@ var notInTests = TableTest{
),
Compare: CompareExactUnordered,
},
// this test currently causes a panic
/*
{
SQLs: sqls(
"select t1._id in (select t2.s1 from in_all_types as t2) from in_all_types as t1",
),
ExpHdrs: hdrs(
hdr("", fldTypeBool),
),
ExpErr: "types 'id' and 'string' are not equatable",
Compare: CompareExactUnordered,
},
*/
{
SQLs: sqls(
"select t1._id not in (select t2._id from in_all_types as t2) from in_all_types as t1",
),
ExpHdrs: hdrs(
hdr("", fldTypeBool),
),
ExpRows: rows(
row(bool(false)),
),
Compare: CompareExactUnordered,
},
// This test fails - re-enable it when the bug is fixed
/*
{
SQLs: sqls(
"select t1._id not in (select t2.id1 from in_all_types as t2) from in_all_types as t1",
),
ExpHdrs: hdrs(
hdr("", fldTypeBool),
),
ExpRows: rows(
row(bool(true)),
),
Compare: CompareExactUnordered,
},
*/
// This test also fails.
// Once re-enabled and passing, it provides coverage for expressionanalyzer.go
// (*ExecutionPlanner).analyzeBinaryExpression in the case where the left hand side
// of the IN contains a JOIN.
/*
{
SQLs: sqls(
"select a1._id from in_all_types a1 inner join in_all_types a2 on a1._id=a2._id where a1._id not in (select _id from in_all_types);",
),
ExpHdrs: hdrs(
hdr("", fldTypeBool),
),
ExpRows: rows(
row(bool(true)),
),
Compare: CompareExactUnordered,
},
*/
},
}