From 83e08efa0af1fd29e2dcbb00594af43321161751 Mon Sep 17 00:00:00 2001 From: Seebs Date: Wed, 5 Oct 2022 15:09:04 -0500 Subject: [PATCH] abandon idk change detection for now the "changes" rule appears not to be good at detecting changes in some cases. specifically, it appears that you have to be in an "only:" clause, not a "rules" clause, to trigger the merge-specific behavior which checks the entire merge branch instead of the top commit, but that means that if your last commit doesn't touch IDK, we don't run IDK tests, and I haven't been able to fix this yet. So for now, revert the IDK-specific change detection behavior, which slows CI down but gets us test coverage. --- .gitlab/.gitlab-ci.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.gitlab/.gitlab-ci.yml b/.gitlab/.gitlab-ci.yml index 494e6e047..c1b95e284 100644 --- a/.gitlab/.gitlab-ci.yml +++ b/.gitlab/.gitlab-ci.yml @@ -275,9 +275,6 @@ run go tests idk race: retry: 1 rules: - if: '$CI_COMMIT_TAG == null && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")' - changes: - - idk - - client script: - echo "Running test-all-race" - cd ./idk/ @@ -309,9 +306,6 @@ run go tests idk shard transactional: retry: 1 rules: - if: '$CI_COMMIT_TAG == null && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")' - changes: - - idk - - client script: - echo "Running shard transactional tests" - cd ./idk/ @@ -352,9 +346,6 @@ run go tests idk 533: - make shutdown rules: - if: '$CI_COMMIT_TAG == null && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")' - changes: - - idk - - client tags: - shell - aws @@ -384,9 +375,6 @@ run go tests idk sasl: - make shutdown rules: - if: '$CI_COMMIT_TAG == null && ($CI_PIPELINE_SOURCE == "push" || $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "web")' - changes: - - idk - - client tags: - shell - aws