scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

FB-1719: implement SQL3 lower() (#2358)

Browse source 
* Implemented SQL3 LOWER()

(cherry picked from commit 4773aabc4e)
This commit is contained in:
Bruce Baranowski 2022-12-13 14:59:05 -05:00 • committed by Joe Friedrich
parent 748fdc3741
commit 838bc2dadb
4 changed files with 55 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sql3/planner/expression.go
View file

@ -1482,6 +1482,8 @@ func (n *callPlanExpression) Evaluate(currentRow []interface{}) (interface{}, er
return n.EvaluateUpper(currentRow)
case "SUBSTRING":
return n.EvaluateSubstring(currentRow)
case "LOWER":
return n.EvaluateLower(currentRow)
case "REPLACEALL":
return n.EvaluateReplaceAll(currentRow)
case "TRIM":

2
sql3/planner/expressionanalyzercall.go
View file

@ -247,6 +247,8 @@ func (p *ExecutionPlanner) analyzeCallExpression(call *parser.Call, scope parser
return p.analyzeFunctionUpper(call, scope)
case "SUBSTRING":
return p.analyseFunctionSubstring(call, scope)
case "LOWER":
return p.analyzeFunctionLower(call, scope)
case "REPLACEALL":
return p.analyseFunctionReplaceAll(call, scope)
case "TRIM":

25
sql3/planner/inbuiltfunctionsstring.go
View file

@ -44,6 +44,20 @@ func (p *ExecutionPlanner) analyseFunctionSubstring(call *parser.Call, scope par
return call, nil
}
func (p *ExecutionPlanner) analyzeFunctionLower(call *parser.Call, scope parser.Statement) (parser.Expr, error) {
if len(call.Args) != 1 {
return nil, sql3.NewErrCallParameterCountMismatch(call.Rparen.Line, call.Rparen.Column, call.Name.Name, 1, len(call.Args))
}
if !typeIsString(call.Args[0].DataType()) {
return nil, sql3.NewErrStringExpressionExpected(call.Args[0].Pos().Line, call.Args[0].Pos().Column)
}
call.ResultDataType = parser.NewDataTypeString()
return call, nil
}
func (p *ExecutionPlanner) analyseFunctionReplaceAll(call *parser.Call, scope parser.Statement) (parser.Expr, error) {
if len(call.Args) != 3 {
return nil, sql3.NewErrCallParameterCountMismatch(call.Rparen.Line, call.Rparen.Column, call.Name.Name, 3, len(call.Args))
@ -146,6 +160,15 @@ func (n *callPlanExpression) EvaluateSubstring(currentRow []interface{}) (interf
return stringArgOne[startIndex:endIndex], nil
}
func (n *callPlanExpression) EvaluateLower(currentRow []interface{}) (interface{}, error) {
stringArgOne, err := evaluateStringArg(n.args[0], currentRow)
if err != nil {
return nil, err
}
return strings.ToLower(stringArgOne), nil
}
// takes string, findstring, replacestring.
// replaces all occurances of findstring with replacestring
func (n *callPlanExpression) EvaluateReplaceAll(currentRow []interface{}) (interface{}, error) {
@ -177,7 +200,7 @@ func evaluateStringArg(n types.PlanExpression, currentRow []interface{}) (string
return stringArgOne, nil
}
//Analyze function for Trim
// Analyze function for Trim
func (p *ExecutionPlanner) analyseFunctionTrim(call *parser.Call, scope parser.Statement) (parser.Expr, error) {
//one argument for Trim Function
if len(call.Args) != 1 {

27
sql3/test/defs/defs_string_functions.go
View file

@ -135,6 +135,33 @@ var stringScalarFunctionsTests = TableTest{
),
ExpErr: "string expression expected",
},
{
name: "StringLower",
SQLs: sqls(
"select lower('AaBbCcDdEeFfGg-_0123')",
),
ExpHdrs: hdrs(
hdr("", fldTypeString),
),
ExpRows: rows(
row(string("aabbccddeeffgg-_0123")),
),
Compare: CompareExactOrdered,
},
{
name: "IncorrectArgumentsforLower",
SQLs: sqls(
"select lower('LOWER','lower')",
),
ExpErr: "'lower': count of formal parameters (1) does not match count of actual parameters (2)",
},
{
name: "IncorrectInputforLower",
SQLs: sqls(
"select lower(1234)",
),
ExpErr: "string expression expected",
},
{
name: "ReplaceAllString",
SQLs: sqls(