scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-06 00:25:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove import count optimization.

Browse source
This commit is contained in:
Ben Johnson 2016-09-16 11:36:54 -06:00
parent 3907414a10
commit 7c07cdf304
No known key found for this signature in database
GPG key ID: 81741CD251883081
1 changed files with 9 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
fragment.go
View file

@ -871,11 +871,10 @@ func (f *Fragment) Import(bitmapIDs, profileIDs []uint64) error {
// Process every bit.
// If an error occurs then reopen the storage.
if err := func() error {
lastID := uint64(0)
bmCounter := uint64(0)
var bitmap *Bitmap
set := make(map[uint64]struct{})
for i := range bitmapIDs {
bitmapID, profileID := bitmapIDs[i], profileIDs[i]
// Determine the position of the bit in the storage.
pos, err := f.pos(bitmapID, profileID)
if err != nil {
@ -888,25 +887,19 @@ func (f *Fragment) Import(bitmapIDs, profileIDs []uint64) error {
return err
}
// import optimization to avoid linear foreach calls
// slight risk of concurrent cache counter being off but
// no real danger
if i == 0 || bitmapID != lastID {
bitmap = f.bitmap(bitmapID)
if i != 0 {
f.cache.Add(lastID, bmCounter)
}
bmCounter = bitmap.Count()
lastID = bitmapID
}
// Mark bitmap to be updated in cache.
if changed {
bmCounter += 1
set[bitmapID] = struct{}{}
}
// Invalidate block checksum.
delete(f.checksums, int(bitmapID/HashBlockSize))
}
f.cache.Add(lastID, bmCounter)
// Update cache counts for all bitmaps.
for bitmapID := range set {
f.cache.Add(bitmapID, f.bitmap(bitmapID).Count())
}
f.cache.Invalidate()
return nil