Error ErrInputDefinitionValueMap

This commit is contained in:
Michael Baird 2017-06-29 11:23:36 -05:00
parent 57a67f16ed
commit 7abab7b795
3 changed files with 4 additions and 4 deletions

View file

@ -15,7 +15,6 @@
package pilosa
import (
"errors"
"fmt"
"io/ioutil"
"os"
@ -209,7 +208,7 @@ func (a *Action) Validate() error {
switch a.ValueDestination {
case InputMapping:
if len(a.ValueMap) == 0 {
return errors.New("valueMap required for map")
return ErrInputDefinitionValueMap
}
}
return nil

View file

@ -167,8 +167,8 @@ func TestActionValidation(t *testing.T) {
field = pilosa.InputDefinitionField{Name: "id", PrimaryKey: true, Actions: []pilosa.Action{action}}
info = pilosa.InputDefinitionInfo{Frames: []pilosa.InputFrame{frame}, Fields: []pilosa.InputDefinitionField{field}}
err = info.Validate("id")
if !strings.Contains(err.Error(), "valueMap required for map") {
t.Fatalf("Expected valueMap required for map error, actual error: %s", err)
if err != pilosa.ErrInputDefinitionValueMap {
t.Fatalf("Expect error: %s, actual err: %s", pilosa.ErrInputDefinitionValueMap, err)
}
action = pilosa.Action{Frame: "f", ValueDestination: pilosa.InputSingleRowBool, RowID: &rowID}

View file

@ -42,6 +42,7 @@ var (
ErrInputDefinitionColumnLabel = errors.New("PrimaryKey field name does not match columnLabel")
ErrInputDefinitionNameRequired = errors.New("input-definition name required")
ErrInputDefinitionAttrsRequired = errors.New("frames and fields are required")
ErrInputDefinitionValueMap = errors.New("valueMap required for map")
ErrFieldNameRequired = errors.New("field name required")
ErrInvalidFieldType = errors.New("invalid field type")