scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

apply sane numbers when min/max 0 is provided

Browse source
This commit is contained in:
Todd Gruben 2022-04-12 15:47:14 -05:00
parent 54a8754c33
commit 7588912c19
1 changed files with 20 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
index.go
View file

@ -647,24 +647,33 @@ func (i *Index) CreateFieldIfNotExistsWithOptions(name string, opt *FieldOptions
if f := i.fields[name]; f != nil {
return f, nil
}
if opt != nil && (opt.Type == FieldTypeInt || opt.Type == FieldTypeTimestamp) {
min, max := pql.MinMax(0)
// ensure the provided bounds are valid
if opt.Max.Value == 0 {
opt.Max = max
} else if max.LessThan(opt.Max) {
opt.Max = max
}
if opt.Min.Value == 0 {
opt.Min = min
} else if min.GreaterThan(opt.Min) {
opt.Min = min
}
}
// added for backward compatablity with old schemas
if opt != nil && opt.Type == FieldTypeDecimal {
min, max := pql.MinMax(opt.Scale)
// ensure the provided bounds are valid
if max.LessThan(opt.Max) {
if opt.Max.Value == 0 {
opt.Max = max
} else if max.LessThan(opt.Max) {
opt.Max = max
}
if min.GreaterThan(opt.Min) {
if opt.Min.Value == 0 {
opt.Min = min
}
}
if opt != nil && opt.Type == FieldTypeDecimal {
min, max := pql.MinMax(0)
// ensure the provided bounds are valid
if max.LessThan(opt.Max) {
opt.Max = max
}
if min.GreaterThan(opt.Min) {
} else if min.GreaterThan(opt.Min) {
opt.Min = min
}
}