From 7572acb4505f6726fbcb42c000e99463914d83a0 Mon Sep 17 00:00:00 2001 From: Seebs Date: Tue, 18 May 2021 16:36:25 -0500 Subject: [PATCH] drop "another shard" test as it's probably not valid We've got a fairly consistent thing of the API splitting data up into shards before sending it to a field, which it has to do because of clustering, so we don't intend to support the case where you have data from another shard in a data set. Also drop the identical but mislabeled test from TestIntField's corresponding case. --- field_internal_test.go | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/field_internal_test.go b/field_internal_test.go index 23f84bc4c..337909494 100644 --- a/field_internal_test.go +++ b/field_internal_test.go @@ -589,13 +589,6 @@ func TestIntField_MinMaxForShard(t *testing.T) { expMax: ValCount{Val: 20, Count: 2}, expMin: ValCount{Val: 10, Count: 3}, }, - { - name: "middlevals", - columnIDs: []uint64{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 100000000, 100000001}, - values: []int64{10, 20, 10, 10, 20, 11, 12, 11, 13, 11, 44, 1}, - expMax: ValCount{Val: 20, Count: 2}, - expMin: ValCount{Val: 10, Count: 3}, - }, } { t.Run(test.name+strconv.Itoa(i), func(t *testing.T) { if err := f.importValue(qcx, test.columnIDs, test.values, options); err != nil { @@ -756,13 +749,6 @@ func TestDecimalField_MinMaxForShard(t *testing.T) { expMax: ValCount{DecimalVal: &pql.Decimal{Value: 20200, Scale: 3}, Count: 2}, expMin: ValCount{DecimalVal: &pql.Decimal{Value: 10100, Scale: 3}, Count: 3}, }, - { - name: "another shard", - columnIDs: []uint64{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 100000000, 100000001}, - values: []float64{10.1, 20.2, 10.1, 10.1, 20.2, 11, 12, 11, 13, 11, 44.39, 0.23}, - expMax: ValCount{DecimalVal: &pql.Decimal{Value: 20200, Scale: 3}, Count: 2}, - expMin: ValCount{DecimalVal: &pql.Decimal{Value: 10100, Scale: 3}, Count: 3}, - }, } { t.Run(test.name+strconv.Itoa(i), func(t *testing.T) { if err := f.importFloatValue(qcx, test.columnIDs, test.values, options); err != nil {