scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-12 07:41:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Simplified the if statement and made the calculation more precise

Browse source
This commit is contained in:
Ashley Svetlik 2019-06-14 14:30:21 -05:00
parent 77cb1ea6d8
commit 734daf79ee
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
roaring/roaring.go
View file

@ -23,6 +23,7 @@ import (
"math/bits"
"sort"
"unsafe"
"math"
"github.com/pkg/errors"
)
@ -3956,17 +3957,15 @@ func (op *op) UnmarshalBinary(data []byte) error {
// op.value will actually contain the length of values for batch ops
op.value = binary.LittleEndian.Uint64(data[1:9])
if math.MaxInt64/8-13 < int(op.value){
return fmt.Errorf("too big")
}
// Verify checksum.
h := fnv.New32a()
_, _ = h.Write(data[0:9])
if op.typ > 1 {
// The maximum integer value for a int64 is 9223372036854775807
maxInt := 9223372036854775807
maxOpValue := maxInt/8-13
if maxOpValue < int(op.value) {
return fmt.Errorf("too big")
}
if len(data) < int(13+op.value*8) {
return fmt.Errorf("op data truncated - expected %d, got %d", 13+op.value*8, len(data))
}