scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-07 17:15:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'master' into ci-backup

Browse source
This commit is contained in:
tgruben 2021-06-30 14:55:59 -05:00 • committed by GitHub
commit 72b2896178
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
ctl/backup.go
View file

@ -109,7 +109,16 @@ func (cmd *BackupCommand) Run(ctx context.Context) (err error) {
// Backup data for each index.
for _, ii := range schema.Indexes {
if err := cmd.backupIndex(ctx, ii); err != nil {
if err := cmd.backupIndexData(ctx, ii); err != nil {
return err
}
}
// Backup translation data. This has to happen separately, because
// otherwise a field which uses foreign key translation can reasonably
// contain values which got created for the foreign index after we
// backed up that index.
for _, ii := range schema.Indexes {
if err := cmd.backupIndexTranslation(ctx, ii); err != nil {
return err
}
}
@ -164,16 +173,13 @@ func (cmd *BackupCommand) backupIDAllocData(ctx context.Context) error {
return f.Close()
}
// backupIndex backs up all shards for a given index.
func (cmd *BackupCommand) backupIndex(ctx context.Context, ii *pilosa.IndexInfo) error {
// backupIndexTranslation backs up both field and index-wide key translation for
// the given index. it has to run after the index's data has been backed up,
// but also after the data for any index which might have a foreign-key
// relation to this index has been backed up.
func (cmd *BackupCommand) backupIndexTranslation(ctx context.Context, ii *pilosa.IndexInfo) error {
logger := cmd.Logger()
logger.Printf("backing up index: %q", ii.Name)
if err := cmd.backupShards(ctx, ii); err != nil {
return err
}
// Back up translation data after bitmap data so we ensure we can translate all data.
logger.Printf("backing up index translation: %q", ii.Name)
if err := cmd.backupIndexTranslateData(ctx, ii.Name); err != nil {
return err
}
@ -188,7 +194,10 @@ func (cmd *BackupCommand) backupIndex(ctx context.Context, ii *pilosa.IndexInfo)
return nil
}
func (cmd *BackupCommand) backupShards(ctx context.Context, ii *pilosa.IndexInfo) error {
// backupIndexData backs up all shard data for a given index.
func (cmd *BackupCommand) backupIndexData(ctx context.Context, ii *pilosa.IndexInfo) error {
logger := cmd.Logger()
logger.Printf("backing up index data: %q", ii.Name)
shards, err := cmd.client.AvailableShards(ctx, ii.Name)
if err != nil {
return fmt.Errorf("cannot find available shards for index %q: %w", ii.Name, err)