From f03ba0e68255dc29924eca6829f0cf633a98ca6b Mon Sep 17 00:00:00 2001 From: Nia Weiss Date: Wed, 16 Sep 2020 12:30:12 -0400 Subject: [PATCH] add a deprecation warning to Inspect --- server/grpc.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/server/grpc.go b/server/grpc.go index fe23fe744..38d58393e 100644 --- a/server/grpc.go +++ b/server/grpc.go @@ -37,9 +37,10 @@ import ( // GRPCHandler contains methods which handle the various gRPC requests. type GRPCHandler struct { - api *pilosa.API - logger logger.Logger - stats stats.StatsClient + api *pilosa.API + logger logger.Logger + stats stats.StatsClient + inspectDeprecated sync.Once } func NewGRPCHandler(api *pilosa.API) *GRPCHandler { @@ -375,6 +376,10 @@ func ToRowserWrapper(result interface{}) (pb.ToRowser, error) { func (h *GRPCHandler) Inspect(req *pb.InspectRequest, stream pb.Pilosa_InspectServer) error { const defaultLimit = 100000 + h.inspectDeprecated.Do(func() { + h.logger.Printf("DEPRECATED: Inspect is deprecated, please use Extract() instead.") + }) + index, err := h.api.Index(stream.Context(), req.Index) if err != nil { return errToStatusError(err)