scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-09 22:51:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

improve error responses and change switch statement to allow int64

Browse source
This commit is contained in:
Maxton Huff 2021-03-26 13:56:22 -05:00
parent 87412068f1
commit 6c94bfdb5e
1 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
executor.go
View file

@ -1305,19 +1305,24 @@ func (e *executor) executePercentile(ctx context.Context, qcx *Qcx, index string
// get nth
var nthFloat float64
if nthArg, ok := c.Args["nth"].(pql.Decimal); ok {
switch c.Args["nth"].(type) {
case pql.Decimal:
nthFloat = nthArg.Float64()
case int64:
nthFloat = float64(nthArg.ToInt64(0))
default:
return ValCount{}, errors.Errorf("Percentile(): invalid nth type (%f), should be int64 or pql.Decimal", reflect.TypeOf(nthArg))
}
OK := false
switch c.Args["nth"].(type) {
case pql.Decimal:
nthArg, ok := c.Args["nth"].(pql.Decimal)
nthFloat = nthArg.Float64()
OK = ok
case int64:
nthArg, ok := c.Args["nth"].(int64)
nthFloat = float64(nthArg)
OK = ok
default:
return ValCount{}, errors.Errorf("Percentile(): invalid nth type (%f), should be int64 or pql.Decimal", reflect.TypeOf(c.Args["nth"]))
}
if OK {
if nthFloat < 0 || nthFloat > 100.0 {
return ValCount{}, errors.Errorf("Percentile(): invalid nth value (%f), should be >= 0 and <= 100", nthFloat)
}
} else {
} else if c.Args["nth"] == nil {
return ValCount{}, errors.New("Percentile(): nth required")
}