scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-10 23:11:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fb-2056 improve test coverage for alter table statement. (#2332)

Browse source
This commit is contained in:
Vengata Krishnan 2023-03-20 13:02:37 -04:00 • committed by GitHub
parent 72871e6e5d
commit 693ea1c3a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
sql3/sql_complex_test.go
View file

@ -839,7 +839,39 @@ func TestPlanner_AlterTable(t *testing.T) {
t.Fatal(diff)
}
})
// test for adding duplicate column, this test requires column 'f' to be defined beforehand.
t.Run("AlterTableAdd", func(t *testing.T) {
_, _, _, err := sql_test.MustQueryRows(t, server, fmt.Sprintf(`alter table %i add column f int`, c))
if err == nil {
t.Fatal("expected error")
} else {
if err.Error() != "[1:47] duplicate column 'f'" {
t.Fatal(err)
}
}
})
// test for bad column definitions.
t.Run("AlterTableAdd", func(t *testing.T) {
_, _, _, err := sql_test.MustQueryRows(t, server, fmt.Sprintf(`alter table %i add column dt date`, c))
if err == nil {
t.Fatal("expected error")
} else {
if err.Error() != "[1:50] unknown type 'date'" {
t.Fatal(err)
}
}
})
//test for the system rule that enforces the special primary key column "_id" can't be added using alter table statement.
t.Run("AlterTableAdd", func(t *testing.T) {
_, _, _, err := sql_test.MustQueryRows(t, server, fmt.Sprintf(`alter table %i add column _id int`, c))
if err == nil {
t.Fatal("expected error")
} else {
if err.Error() != "[1:47] _id column cannot be added to an existing table" {
t.Fatal(err)
}
}
})
t.Run("AlterTableRename", func(t *testing.T) {
t.Skip("not yet implemented")
results, columns, _, err := sql_test.MustQueryRows(t, server, fmt.Sprintf(`alter table %i rename column f to g`, c))