From 68ce07b45d281fd3d65ff7a737daafda45c4756a Mon Sep 17 00:00:00 2001
From: Michael Baird <mbaird@umbel.com>
Date: Tue, 26 Sep 2017 22:40:55 -0500
Subject: [PATCH] add Open/Close interface to Stats packages

---
 stats.go         | 36 ++++++++++++++++++++++++++++++++++--
 stats_test.go    |  2 ++
 statsd/statsd.go |  3 +++
 3 files changed, 39 insertions(+), 2 deletions(-)

diff --git a/stats.go b/stats.go
index 71f0d56b1..998b84511 100644
--- a/stats.go
+++ b/stats.go
@@ -58,6 +58,12 @@ type StatsClient interface {
 
 	// SetLogger Set the logger output type
 	SetLogger(logger io.Writer)
+
+	// Starts the service
+	Open()
+
+	// Closes the client
+	Close() error
 }
 
 // NopStatsClient represents a client that doesn't do anything.
@@ -74,6 +80,8 @@ func (c *nopStatsClient) Histogram(name string, value float64, rate float64)
 func (c *nopStatsClient) Set(name string, value string, rate float64)                               {}
 func (c *nopStatsClient) Timing(name string, value time.Duration, rate float64)                     {}
 func (c *nopStatsClient) SetLogger(logger io.Writer)                                                {}
+func (c *nopStatsClient) Open()                                                                     {}
+func (c *nopStatsClient) Close() error                                                              { return nil }
 
 // ExpvarStatsClient writes stats out to expvars.
 type ExpvarStatsClient struct {
@@ -145,10 +153,16 @@ func (c *ExpvarStatsClient) Timing(name string, value time.Duration, rate float6
 	c.mu.Unlock()
 }
 
-// SetLogger has no logger
+// SetLogger has no logger.
 func (c *ExpvarStatsClient) SetLogger(logger io.Writer) {
 }
 
+// Open no-op.
+func (c *ExpvarStatsClient) Open() {}
+
+// Close no-op.
+func (c *ExpvarStatsClient) Close() error { return nil }
+
 // MultiStatsClient joins multiple stats clients together.
 type MultiStatsClient []StatsClient
 
@@ -211,13 +225,31 @@ func (a MultiStatsClient) Timing(name string, value time.Duration, rate float64)
 	}
 }
 
-// SetLogger Sets the StatsD logger output type
+// SetLogger Sets the StatsD logger output type.
 func (a MultiStatsClient) SetLogger(logger io.Writer) {
 	for _, c := range a {
 		c.SetLogger(logger)
 	}
 }
 
+// Open starts the stat service.
+func (a MultiStatsClient) Open() {
+	for _, c := range a {
+		c.Open()
+	}
+}
+
+// Close shuts down the stats clients.
+func (a MultiStatsClient) Close() error {
+	for _, c := range a {
+		err := c.Close()
+		if err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
 // UnionStringSlice returns a sorted set of tags which combine a & b.
 func UnionStringSlice(a, b []string) []string {
 	// Sort both sets first.
diff --git a/stats_test.go b/stats_test.go
index 7ed679f21..07254a702 100644
--- a/stats_test.go
+++ b/stats_test.go
@@ -344,3 +344,5 @@ func (c *MockStats) Histogram(name string, value float64, rate float64)    {}
 func (c *MockStats) Set(name string, value string, rate float64)           {}
 func (c *MockStats) Timing(name string, value time.Duration, rate float64) {}
 func (c *MockStats) SetLogger(logger io.Writer)                            {}
+func (c *MockStats) Open()                                                 {}
+func (c *MockStats) Close() error                                          { return nil }
diff --git a/statsd/statsd.go b/statsd/statsd.go
index e55b190ad..d46dd637f 100644
--- a/statsd/statsd.go
+++ b/statsd/statsd.go
@@ -58,6 +58,9 @@ func NewStatsClient(host string) (*StatsClient, error) {
 	}, nil
 }
 
+// Open no-op
+func (c *StatsClient) Open() {}
+
 // Close closes the connection to the agent.
 func (c *StatsClient) Close() error {
 	return c.client.Close()