scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

TxBitmap: track seen container keys

Browse source 
We can't assume that a container we've seen stays present in our bitmap
after possible remove operations. Solution: Track keys seen.
This commit is contained in:
Seebs 2021-03-29 14:39:49 -05:00
parent a94c745a7f
commit 6416b895c0
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tx.go
View file

@ -257,6 +257,9 @@ type TxBitmap struct {
field string
view string
shard uint64
// Container keys we've already snagged containers for, even if
// those containers have since been deleted by remove ops.
seen map[uint64]struct{}
}
func NewTxBitmap(tx Tx, index, field, view string, shard uint64) *TxBitmap {
@ -267,6 +270,7 @@ func NewTxBitmap(tx Tx, index, field, view string, shard uint64) *TxBitmap {
field: field,
view: view,
shard: shard,
seen: make(map[uint64]struct{}),
}
}
@ -288,14 +292,14 @@ func (b *TxBitmap) Remove(a ...uint64) (changed bool, err error) {
func (b *TxBitmap) ensureContainers(a ...uint64) error {
for _, v := range a {
key := highbits(v)
if b.b.Containers.Get(key) != nil {
if _, ok := b.seen[key]; ok {
continue
}
c, err := b.tx.Container(b.index, b.field, b.view, b.shard, key)
if err != nil {
return err
}
b.seen[key] = struct{}{}
b.b.Containers.Put(key, c)
}
return nil
@ -308,6 +312,14 @@ func (b *TxBitmap) Flush() error {
if err := b.tx.PutContainer(b.index, b.field, b.view, b.shard, key, c); err != nil {
return err
}
delete(b.seen, key)
}
// remove containers we have seen but no longer have, because that means
// we deleted everything from them.
for key := range b.seen {
if err := b.tx.RemoveContainer(b.index, b.field, b.view, b.shard, key); err != nil {
return err
}
}
return nil
}