scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-08-28 10:54:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor view validator

Browse source
This commit is contained in:
Linh Vo 2017-05-15 14:56:47 -05:00
parent 384329bc91
commit 5de9a7d0d0
2 changed files with 2 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
client.go
View file

@ -394,15 +394,7 @@ func (c *Client) ExportCSV(ctx context.Context, index, frame, view string, slice
return ErrIndexRequired
} else if frame == "" {
return ErrFrameRequired
}
foundView := false
for _, v := range []string{ViewInverse, ViewStandard} {
if view == v {
foundView = true
break
}
}
if foundView == false {
} else if !(view == ViewStandard || view == ViewInverse) {
return ErrInvalidView
}

11
ctl/export.go
View file

@ -49,22 +49,13 @@ func NewExportCommand(stdin io.Reader, stdout, stderr io.Writer) *ExportCommand
// Run executes the export.
func (cmd *ExportCommand) Run(ctx context.Context) error {
logger := log.New(cmd.Stderr, "", log.LstdFlags)
foundView := false
// Validate arguments.
if cmd.Index == "" {
return pilosa.ErrIndexRequired
} else if cmd.Frame == "" {
return pilosa.ErrFrameRequired
}
for _, v := range []string{pilosa.ViewInverse, pilosa.ViewStandard} {
if cmd.View == v {
foundView = true
break
}
}
if foundView == false {
} else if !(cmd.View == pilosa.ViewStandard || cmd.View == pilosa.ViewInverse) {
return pilosa.ErrInvalidView
}