From 53dfa9b7f2bc8c8249a704551fb139fc2c6696f6 Mon Sep 17 00:00:00 2001 From: Matt Jaffee Date: Fri, 22 Mar 2019 16:24:08 -0500 Subject: [PATCH] remove rename of columnIDs and add comment --- fragment_internal_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fragment_internal_test.go b/fragment_internal_test.go index 219934439..b726d4fe5 100644 --- a/fragment_internal_test.go +++ b/fragment_internal_test.go @@ -2466,11 +2466,11 @@ func (f *fragment) mustSetBits(rowID uint64, columnIDs ...uint64) { } func addToBitmap(bm *roaring.Bitmap, rowID uint64, columnIDs ...uint64) { + // we'll reuse the columnIDs slice and fill it with positions for DirectAddN for i, c := range columnIDs { columnIDs[i] = rowID*ShardWidth + c%ShardWidth } - positions := columnIDs - bm.DirectAddN(positions...) + bm.DirectAddN(columnIDs...) } // Test Various methods of retrieving RowIDs