scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-12 15:51:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Address code review: Fix error handling and add comment

Browse source
This commit is contained in:
Cody Soyland 2018-03-07 09:45:27 -06:00
parent b7b92913d9
commit 42682e12a8
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cluster.go
View file

@ -941,7 +941,7 @@ func (c *Cluster) handleNodeAction(nodeAction nodeAction) error {
if err := c.setStateAndBroadcast(ClusterStateNormal); err != nil {
c.logger().Printf("setStateAndBroadcast error: err=%s", err)
}
return c.setStateAndBroadcast(ClusterStateNormal)
return err
}
// j.Run() runs in a goroutine because in the case where the

2
server/cluster_test.go
View file

@ -556,6 +556,8 @@ func TestClusterResize_RemoveNode(t *testing.T) {
t.Fatal(err)
}
// This is an attempt to ensure there is data on both nodes, but is not guaranteed.
// TODO: Deterministic node IDs would ensure consistent results
setBits := ""
for i := 0; i < 20; i++ {
setBits += fmt.Sprintf("SetBit(rowID=1, frame=\"f\", columnID=%d) ", i*pilosa.SliceWidth)