scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-09 22:51:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Optimize row.Includes

Browse source
This commit is contained in:
Todd Gruben 2020-06-10 13:12:38 -05:00
parent ec9474114a
commit 416f332070
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
row.go
View file

@ -510,14 +510,10 @@ func (r *Row) Columns() []uint64 {
// Includes returns true if the row contains the given column.
func (r *Row) Includes(col uint64) bool {
// TODO: improve the efficiency of this method by
// performing the column filter at the bitmap level
// rather than iterating through the results here.
shard := col / ShardWidth
for i := range r.segments {
for _, c := range r.segments[i].Columns() {
if c == col {
return true
}
if r.segments[i].shard == shard {
return r.segments[i].data.Contains(col)
}
}
return false