From 407d52baa0532cbb4de82e5b5b2fdda5d00ede71 Mon Sep 17 00:00:00 2001 From: Garrison Davis Date: Fri, 4 Nov 2022 14:14:35 -0600 Subject: [PATCH] Fix server.GetIndexes userInfo logic userInfo at the relevant line can be nil here. We check later if the userInfo != nil (and assure it passes authn/authz) or if userInfo == nil then we return all the indexes we can find. --- server/grpc.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/server/grpc.go b/server/grpc.go index bc53433f9..34c400f93 100644 --- a/server/grpc.go +++ b/server/grpc.go @@ -463,10 +463,7 @@ func (h *GRPCHandler) GetIndex(ctx context.Context, req *pb.GetIndexRequest) (*p // GetIndexes returns a list of all Indexes func (h *GRPCHandler) GetIndexes(ctx context.Context, req *pb.GetIndexesRequest) (*pb.GetIndexesResponse, error) { - userInfo, ok := authn.GetUserInfo(ctx) - if !ok { - return nil, status.Error(codes.InvalidArgument, "malformed auth header") - } + userInfo, _ := authn.GetUserInfo(ctx) // nil is a valid userInfo here schema, err := h.api.Schema(ctx, false) if err != nil { return nil, errToStatusError(err)