From 3b676a7cbd13032a14efac8797e65b3d7d940c10 Mon Sep 17 00:00:00 2001 From: Travis Date: Tue, 10 Mar 2020 14:36:55 -0500 Subject: [PATCH] fix linter warnings --- pql/parser.go | 4 +++- pql/pqlpeg_test.go | 8 ++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/pql/parser.go b/pql/parser.go index 8482359fb..b3ad984f9 100644 --- a/pql/parser.go +++ b/pql/parser.go @@ -59,7 +59,9 @@ func (p *parser) Parse() (*Query, error) { p.PQL = PQL{ Buffer: string(buf), } - p.Init() + if err := p.Init(); err != nil { + return nil, errors.Wrap(err, "initializing") + } err = p.PQL.Parse() if err != nil { return nil, errors.Wrap(err, "parsing") diff --git a/pql/pqlpeg_test.go b/pql/pqlpeg_test.go index 48643ec2f..faf50056f 100644 --- a/pql/pqlpeg_test.go +++ b/pql/pqlpeg_test.go @@ -24,7 +24,9 @@ import ( func TestPEG(t *testing.T) { p := PQL{Buffer: ` SetBit(Union(Zitmap(row==4), Intersect(Qitmap(blah>4), Ritmap(field="http://zoo9.com=\\'hello' and \"hello\"")), Hitmap(row=ag-bee)), a="4z", b=5) Count(Union(Witmap(row=5.73, frame=.10), Row(zztop><[2, 9]))) TopN(blah, fields=["hello", "goodbye", "zero"])`[1:]} - p.Init() + if err := p.Init(); err != nil { + t.Fatalf("initialization error: %v", err) + } err := p.Parse() if err != nil { t.Fatalf("parse error: %v", err) @@ -32,7 +34,9 @@ SetBit(Union(Zitmap(row==4), Intersect(Qitmap(blah>4), Ritmap(field="http://zoo9 p.Execute() p = PQL{Buffer: `SetRowAttrs(attr="http://zoo9.com=\\'hello' "and \"hello\"")`} - p.Init() + if err := p.Init(); err != nil { + t.Fatalf("initialization error: %v", err) + } err = p.Parse() if err == nil { t.Fatalf("should have been an error because of the interior unescaped double quote")