From 338f69b71d2b4c9ef131199b882a64f990c056ed Mon Sep 17 00:00:00 2001 From: Travis Turner Date: Wed, 26 Sep 2018 14:19:51 -0500 Subject: [PATCH] replace switch with simplified if statement --- executor.go | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/executor.go b/executor.go index 53a39d04e..9c52573b8 100644 --- a/executor.go +++ b/executor.go @@ -1226,11 +1226,7 @@ func (e *executor) executeSetRow(ctx context.Context, index string, c *pql.Call, if field == nil { return false, ErrFieldNotFound } - - switch field.Type() { - case FieldTypeSet: - // These field types support SetRow(). - default: + if field.Type() != FieldTypeSet { return false, fmt.Errorf("SetRow() is not supported on %s field types", field.Type()) } @@ -1298,11 +1294,11 @@ func (e *executor) executeSetRowShard(ctx context.Context, index string, c *pql. return false, errors.Wrapf(err, "creating fragment: %d", shard) } } - cleared, err := fragment.setRow(src, rowID) + set, err := fragment.setRow(src, rowID) if err != nil { return false, errors.Wrapf(err, "setting row %d on view %s shard %d", rowID, viewStandard, shard) } - changed = changed || cleared + changed = changed || set return changed, nil }