scriptoriumadmin/featurebase
1
0
Fork 0
mirror of https://github.com/featurebasedb/featurebase.git synced 2026-09-07 00:55:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove extra index lookup

Browse source
This commit is contained in:
Travis 2020-05-06 13:04:46 -05:00
parent 994ac5aad8
commit 2ca4e971f1
No known key found for this signature in database
GPG key ID: 37080CC2042BA34E
1 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
executor.go
View file

@ -673,33 +673,32 @@ func (e *executor) executeFieldValueCall(ctx context.Context, index string, c *p
return ValCount{}, errors.New("FieldValue(): field required")
}
// Fetch field.
field := e.Holder.Field(index, fieldName)
if field == nil {
return ValCount{}, ErrFieldNotFound
}
// Fetch index.
idx := e.Holder.Index(index)
if idx == nil {
return ValCount{}, ErrIndexNotFound
}
var colID uint64
// Fetch field.
field := idx.Field(fieldName)
if field == nil {
return ValCount{}, ErrFieldNotFound
}
var colID uint64
if colKey, ok := c.Args["column"].(string); ok && idx.Keys() {
if id, err := e.Cluster.translateIndexKey(ctx, index, colKey); err != nil {
id, err := e.Cluster.translateIndexKey(ctx, index, colKey)
if err != nil {
return ValCount{}, errors.Wrap(err, "getting column id")
} else {
colID = id
}
colID = id
} else {
if id, ok, err := c.UintArg("column"); !ok || err != nil {
id, ok, err := c.UintArg("column")
if !ok || err != nil {
// TODO: this error is getting swallowed somewhere (via curl)
return ValCount{}, errors.Wrap(err, "getting column argument")
} else {
colID = id
}
colID = id
}
shard := colID / ShardWidth